Skip to content

Remove max_request_body_size: none option value #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cleptric merged 1 commit into from
Oct 21, 2025
Merged

Remove max_request_body_size: none option value #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions UPGRADE-5.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,17 @@ The following deprecated methods have been removed:
### EventType Changes

The `metrics` event type has been removed from `EventType::cases()` as metrics are no longer supported.

### Request Body Size Option Value Changed

The `max_request_body_size` option value `'none'` has been renamed to `'never'` for consistency:

```php
// Before (4.x)
$options->setMaxRequestBodySize('none');

// After (5.0)
$options->setMaxRequestBodySize('never');
```

The allowed values for this option are now: `'never'`, `'small'`, `'medium'`, `'always'`.
2 changes: 1 addition & 1 deletion src/Integration/RequestIntegration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ private function isRequestBodySizeWithinReadBounds(int $requestBodySize, string
return false;
}

if ($maxRequestBodySize === 'none' || $maxRequestBodySize === 'never') {
if ($maxRequestBodySize === 'never') {
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -963,7 +963,7 @@ private function configureOptions(OptionsResolver $resolver): void
$resolver->setAllowedTypes('max_request_body_size', 'string');
$resolver->setAllowedTypes('class_serializers', 'array');

$resolver->setAllowedValues('max_request_body_size', ['none', 'never', 'small', 'medium', 'always']);
$resolver->setAllowedValues('max_request_body_size', ['never', 'small', 'medium', 'always']);
$resolver->setAllowedValues('dsn', \Closure::fromCallable([$this, 'validateDsnOption']));
$resolver->setAllowedValues('max_breadcrumbs', \Closure::fromCallable([$this, 'validateMaxBreadcrumbsOptions']));
$resolver->setAllowedValues('class_serializers', \Closure::fromCallable([$this, 'validateClassSerializersOption']));
Expand Down
19 changes: 0 additions & 19 deletions tests/Integration/RequestIntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,25 +226,6 @@ public static function invokeDataProvider(): iterable
null,
];

yield [
[
'max_request_body_size' => 'none',
],
(new ServerRequest('POST', 'http://www.example.com/foo'))
->withHeader('Content-Length', '3')
->withBody(Utils::streamFor('foo')),
[
'url' => 'http://www.example.com/foo',
'method' => 'POST',
'headers' => [
'Host' => ['www.example.com'],
'Content-Length' => ['3'],
],
],
null,
null,
];

yield [
[
'max_request_body_size' => 'never',
Expand Down