Conversation
Collaborator
|
Worth seeing this as an opportunity to remove psalm (#1898) to prevent running three tools and see how it works before we commit? Ideally we have a single tool instead of many to prevent them disagreeing with each other. |
Contributor
Author
Good point, I make sure to remove psalm before this gets merged. I think we have to have Mago running for some time in the repo to see how well it works.
Yes, that is my goal as well. So far it seems quite powerful and I'm fairly optimistic it can replace all other tools (including PHP-CS-FIXER) |
giortzisg
approved these changes
Mar 16, 2026
# Conflicts: # .github/workflows/ci.yml # .github/workflows/static-analysis.yaml # composer.json # src/Serializer/EnvelopItems/TransactionItem.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing Mago to the PHP SDK. For the initial version, I added all current failures to the baseline file to keep the PR small regarding code changes.
closes PHP-69