ref(logs): use RingBuffer for logs when not using log_flush_threshold#2058
Open
ref(logs): use RingBuffer for logs when not using log_flush_threshold#2058
log_flush_threshold#2058Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the storage for logs to a
RingBufferwhenlog_flush_thresholdis not set. This prevents unbounded memory growth and will rather drop old logs instead of adding potential to trigger OOM. It has a hard cap of 1000, which is reasonably high because envelopes with more than 1000 logs are likely to be above the envelope limit of 1MB which would be dropped by ingestion anyway.The PR also introduces a
TelemetryStorageclass, which wraps the regular array andRingBufferinto a single storage class so that it can be reused by metrics and also to provide a simpler interface in the aggregators.closes PHP-76