ci: Address warden review feedback

stephanie-anderson · claude · stephanie-anderson · commit 349e6a589f7d · 2026-03-26T19:44:44.000+01:00
- Add requirements*.txt to path filters so dependency changes trigger CI
- Gate job now also fails if the changes detection job itself fails,
  preventing untested code from passing CI when change detection errors

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -37,6 +37,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
 
   lint:
diff --git a/.github/workflows/test-integrations-agents.yml b/.github/workflows/test-integrations-agents.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-agents:
     needs: changes
@@ -111,6 +112,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-agents.result != 'success' && needs.test-agents.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-agents.result != 'success' && needs.test-agents.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-ai-workflow.yml b/.github/workflows/test-integrations-ai-workflow.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-ai_workflow:
     needs: changes
@@ -115,6 +116,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-ai_workflow.result != 'success' && needs.test-ai_workflow.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-ai_workflow.result != 'success' && needs.test-ai_workflow.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-ai.yml b/.github/workflows/test-integrations-ai.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-ai:
     needs: changes
@@ -131,6 +132,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-ai.result != 'success' && needs.test-ai.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-ai.result != 'success' && needs.test-ai.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-cloud.yml b/.github/workflows/test-integrations-cloud.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-cloud:
     needs: changes
@@ -127,6 +128,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-cloud.result != 'success' && needs.test-cloud.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-cloud.result != 'success' && needs.test-cloud.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-common.yml b/.github/workflows/test-integrations-common.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-common:
     needs: changes
@@ -107,6 +108,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-common.result != 'success' && needs.test-common.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-common.result != 'success' && needs.test-common.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-dbs.yml b/.github/workflows/test-integrations-dbs.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-dbs:
     needs: changes
@@ -147,6 +148,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-dbs.result != 'success' && needs.test-dbs.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-dbs.result != 'success' && needs.test-dbs.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-flags.yml b/.github/workflows/test-integrations-flags.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-flags:
     needs: changes
@@ -119,6 +120,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-flags.result != 'success' && needs.test-flags.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-flags.result != 'success' && needs.test-flags.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-gevent.yml b/.github/workflows/test-integrations-gevent.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-gevent:
     needs: changes
@@ -107,6 +108,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-gevent.result != 'success' && needs.test-gevent.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-gevent.result != 'success' && needs.test-gevent.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-graphql.yml b/.github/workflows/test-integrations-graphql.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-graphql:
     needs: changes
@@ -119,6 +120,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-graphql.result != 'success' && needs.test-graphql.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-graphql.result != 'success' && needs.test-graphql.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-mcp.yml b/.github/workflows/test-integrations-mcp.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-mcp:
     needs: changes
@@ -111,6 +112,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-mcp.result != 'success' && needs.test-mcp.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-mcp.result != 'success' && needs.test-mcp.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-misc.yml b/.github/workflows/test-integrations-misc.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-misc:
     needs: changes
@@ -139,6 +140,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-misc.result != 'success' && needs.test-misc.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-misc.result != 'success' && needs.test-misc.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-network.yml b/.github/workflows/test-integrations-network.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-network:
     needs: changes
@@ -115,6 +116,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-network.result != 'success' && needs.test-network.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-network.result != 'success' && needs.test-network.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-tasks.yml b/.github/workflows/test-integrations-tasks.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-tasks:
     needs: changes
@@ -142,6 +143,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-tasks.result != 'success' && needs.test-tasks.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-tasks.result != 'success' && needs.test-tasks.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-web-1.yml b/.github/workflows/test-integrations-web-1.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-web_1:
     needs: changes
@@ -137,6 +138,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-web_1.result != 'success' && needs.test-web_1.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-web_1.result != 'success' && needs.test-web_1.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/.github/workflows/test-integrations-web-2.yml b/.github/workflows/test-integrations-web-2.yml
@@ -45,6 +45,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
   test-web_2:
     needs: changes
@@ -143,6 +144,8 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-web_2.result != 'success' && needs.test-web_2.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-web_2.result != 'success' && needs.test-web_2.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
diff --git a/scripts/split_tox_gh_actions/templates/base.jinja b/scripts/split_tox_gh_actions/templates/base.jinja
@@ -53,6 +53,7 @@ jobs:
               - '**/*.toml'
               - '**/*.ini'
               - 'Makefile'
+              - 'requirements*.txt'
               - '.github/workflows/**'
 
 {% include "test_group.jinja" %}
diff --git a/scripts/split_tox_gh_actions/templates/check_required.jinja b/scripts/split_tox_gh_actions/templates/check_required.jinja
@@ -6,6 +6,8 @@
     runs-on: ubuntu-22.04
     steps:
       - name: Check for failures
-        if: needs.test-{{ lowercase_group }}.result != 'success' && needs.test-{{ lowercase_group }}.result != 'skipped'
+        if: |
+          needs.changes.result == 'failure' ||
+          (needs.test-{{ lowercase_group }}.result != 'success' && needs.test-{{ lowercase_group }}.result != 'skipped')
         run: |
           echo "One of the dependent jobs has failed. You may need to re-run it." && exit 1
