Skip to content

Commit 5e89884

Browse files
committed
fix: prevent duplicate spans
1 parent 5d2ee24 commit 5e89884

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

sentry_sdk/integrations/pyreqwest.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
from pyreqwest.client import ClientBuilder, SyncClientBuilder # type: ignore[import-not-found]
2323
from pyreqwest.request import ( # type: ignore[import-not-found]
2424
Request,
25-
RequestBuilder,
26-
SyncRequestBuilder,
2725
OneOffRequestBuilder,
2826
SyncOneOffRequestBuilder,
2927
)
@@ -47,11 +45,7 @@ def _patch_pyreqwest() -> None:
4745
_patch_builder_method(ClientBuilder, "build", sentry_async_middleware)
4846
_patch_builder_method(SyncClientBuilder, "build", sentry_sync_middleware)
4947

50-
# Patch Request Builders (for simple requests and manual request building)
51-
_patch_builder_method(RequestBuilder, "build", sentry_async_middleware)
52-
_patch_builder_method(RequestBuilder, "build_streamed", sentry_async_middleware)
53-
_patch_builder_method(SyncRequestBuilder, "build", sentry_sync_middleware)
54-
_patch_builder_method(SyncRequestBuilder, "build_streamed", sentry_sync_middleware)
48+
# Patch Request Builders
5549
_patch_builder_method(OneOffRequestBuilder, "send", sentry_async_middleware)
5650
_patch_builder_method(SyncOneOffRequestBuilder, "send", sentry_sync_middleware)
5751

tests/integrations/pyreqwest/test_pyreqwest.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def test_sync_client_spans(sentry_init, capture_events, server_port):
6565
assert response.status == 200
6666

6767
(event,) = events
68+
assert len(event["spans"]) == 1
6869
span = event["spans"][0]
6970
assert span["op"] == "http.client"
7071
assert span["description"] == f"GET {url}"
@@ -85,6 +86,7 @@ async def test_async_client_spans(sentry_init, capture_events, server_port):
8586
assert response.status == 200
8687

8788
(event,) = events
89+
assert len(event["spans"]) == 1
8890
span = event["spans"][0]
8991
assert span["op"] == "http.client"
9092
assert span["description"] == f"GET {url}"
@@ -103,6 +105,7 @@ def test_sync_simple_request_spans(sentry_init, capture_events, server_port):
103105
assert response.status == 200
104106

105107
(event,) = events
108+
assert len(event["spans"]) == 1
106109
span = event["spans"][0]
107110
assert span["op"] == "http.client"
108111
assert span["description"] == f"GET {url}"
@@ -119,6 +122,7 @@ async def test_async_simple_request_spans(sentry_init, capture_events, server_po
119122
assert response.status == 200
120123

121124
(event,) = events
125+
assert len(event["spans"]) == 1
122126
span = event["spans"][0]
123127
assert span["op"] == "http.client"
124128
assert span["description"] == f"GET {url}"

0 commit comments

Comments
 (0)