Skip to content

Commit 7d6ad08

Browse files
test(openai-agents): Stop expecting a specific function name (#5623)
Stop asserting a specific value for the the function name in the `on_invoke_tool` field of entries within the `gen_ai.request.available_tools attribute`.
1 parent 9a7ee50 commit 7d6ad08

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

tests/integrations/openai_agents/test_openai_agents.py

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1231,7 +1231,7 @@ def simple_test_tool(message: str) -> str:
12311231
"type": "object",
12321232
"additionalProperties": False,
12331233
},
1234-
"on_invoke_tool": "<function agents.tool.function_tool.<locals>._create_function_tool.<locals>._on_invoke_tool>",
1234+
"on_invoke_tool": mock.ANY,
12351235
"strict_json_schema": True,
12361236
"is_enabled": True,
12371237
}
@@ -1259,16 +1259,17 @@ def simple_test_tool(message: str) -> str:
12591259
}
12601260
)
12611261

1262-
available_tools = safe_serialize(available_tools)
1263-
12641262
assert transaction["transaction"] == "test_agent workflow"
12651263
assert transaction["contexts"]["trace"]["origin"] == "auto.ai.openai_agents"
12661264

12671265
assert agent_span["description"] == "invoke_agent test_agent"
12681266
assert agent_span["origin"] == "auto.ai.openai_agents"
12691267
assert agent_span["data"]["gen_ai.agent.name"] == "test_agent"
12701268
assert agent_span["data"]["gen_ai.operation.name"] == "invoke_agent"
1271-
assert agent_span["data"]["gen_ai.request.available_tools"] == available_tools
1269+
assert (
1270+
json.loads(agent_span["data"]["gen_ai.request.available_tools"])
1271+
== available_tools
1272+
)
12721273
assert agent_span["data"]["gen_ai.request.max_tokens"] == 100
12731274
assert agent_span["data"]["gen_ai.request.model"] == "gpt-4"
12741275
assert agent_span["data"]["gen_ai.request.temperature"] == 0.7
@@ -1279,7 +1280,10 @@ def simple_test_tool(message: str) -> str:
12791280
assert ai_client_span1["data"]["gen_ai.operation.name"] == "chat"
12801281
assert ai_client_span1["data"]["gen_ai.system"] == "openai"
12811282
assert ai_client_span1["data"]["gen_ai.agent.name"] == "test_agent"
1282-
assert ai_client_span1["data"]["gen_ai.request.available_tools"] == available_tools
1283+
assert (
1284+
json.loads(ai_client_span1["data"]["gen_ai.request.available_tools"])
1285+
== available_tools
1286+
)
12831287
assert ai_client_span1["data"]["gen_ai.request.max_tokens"] == 100
12841288
assert ai_client_span1["data"]["gen_ai.request.messages"] == safe_serialize(
12851289
[
@@ -1320,11 +1324,7 @@ def simple_test_tool(message: str) -> str:
13201324
assert tool_span["data"]["gen_ai.agent.name"] == "test_agent"
13211325
assert tool_span["data"]["gen_ai.operation.name"] == "execute_tool"
13221326
assert (
1323-
re.sub(
1324-
"<.*>(,)",
1325-
r"'NOT_CHECKED'\1",
1326-
agent_span["data"]["gen_ai.request.available_tools"],
1327-
)
1327+
json.loads(agent_span["data"]["gen_ai.request.available_tools"])
13281328
== available_tools
13291329
)
13301330
assert tool_span["data"]["gen_ai.request.max_tokens"] == 100
@@ -1342,11 +1342,7 @@ def simple_test_tool(message: str) -> str:
13421342
assert ai_client_span2["data"]["gen_ai.agent.name"] == "test_agent"
13431343
assert ai_client_span2["data"]["gen_ai.operation.name"] == "chat"
13441344
assert (
1345-
re.sub(
1346-
"<.*>(,)",
1347-
r"'NOT_CHECKED'\1",
1348-
agent_span["data"]["gen_ai.request.available_tools"],
1349-
)
1345+
json.loads(agent_span["data"]["gen_ai.request.available_tools"])
13501346
== available_tools
13511347
)
13521348
assert ai_client_span2["data"]["gen_ai.request.max_tokens"] == 100

0 commit comments

Comments
 (0)