Skip to content

Commit 7d966bd

Browse files
alexander-alderman-webbalexander-alderman-webb
committed
rename responses
1 parent 298245d commit 7d966bd

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

‎tests/integrations/openai_agents/test_openai_agents.py‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ async def test_handoff_span(sentry_init, capture_events, get_model_response):
958958
handoffs=[secondary_agent],
959959
)
960960

961-
first_response = get_model_response(
961+
handoff_response = get_model_response(
962962
Response(
963963
id="resp_tool_123",
964964
output=[
@@ -990,7 +990,7 @@ async def test_handoff_span(sentry_init, capture_events, get_model_response):
990990
)
991991
)
992992

993-
second_response = get_model_response(
993+
final_response = get_model_response(
994994
Response(
995995
id="resp_final_123",
996996
output=[
@@ -1031,7 +1031,7 @@ async def test_handoff_span(sentry_init, capture_events, get_model_response):
10311031
with patch.object(
10321032
primary_agent.model._client._client,
10331033
"send",
1034-
side_effect=[first_response, second_response],
1034+
side_effect=[handoff_response, final_response],
10351035
) as _:
10361036
sentry_init(
10371037
integrations=[OpenAIAgentsIntegration()],
@@ -1085,7 +1085,7 @@ async def test_max_turns_before_handoff_span(
10851085
handoffs=[secondary_agent],
10861086
)
10871087

1088-
first_response = get_model_response(
1088+
handoff_response = get_model_response(
10891089
Response(
10901090
id="resp_tool_123",
10911091
output=[
@@ -1117,7 +1117,7 @@ async def test_max_turns_before_handoff_span(
11171117
)
11181118
)
11191119

1120-
second_response = get_model_response(
1120+
final_response = get_model_response(
11211121
Response(
11221122
id="resp_final_123",
11231123
output=[
@@ -1158,7 +1158,7 @@ async def test_max_turns_before_handoff_span(
11581158
with patch.object(
11591159
primary_agent.model._client._client,
11601160
"send",
1161-
side_effect=[first_response, second_response],
1161+
side_effect=[handoff_response, final_response],
11621162
) as _:
11631163
sentry_init(
11641164
integrations=[OpenAIAgentsIntegration()],
@@ -1206,7 +1206,7 @@ def simple_test_tool(message: str) -> str:
12061206
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
12071207
agent_with_tool = test_agent.clone(tools=[simple_test_tool], model=model)
12081208

1209-
first_response = get_model_response(
1209+
tool_call_response = get_model_response(
12101210
Response(
12111211
id="resp_tool_123",
12121212
output=[
@@ -1238,7 +1238,7 @@ def simple_test_tool(message: str) -> str:
12381238
)
12391239
)
12401240

1241-
second_response = get_model_response(
1241+
final_response = get_model_response(
12421242
Response(
12431243
id="resp_final_123",
12441244
output=[
@@ -1279,7 +1279,7 @@ def simple_test_tool(message: str) -> str:
12791279
with patch.object(
12801280
agent_with_tool.model._client._client,
12811281
"send",
1282-
side_effect=[first_response, second_response],
1282+
side_effect=[tool_call_response, final_response],
12831283
) as _:
12841284
sentry_init(
12851285
integrations=[OpenAIAgentsIntegration()],
@@ -1842,7 +1842,7 @@ async def test_mcp_tool_execution_spans(
18421842
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
18431843
agent = test_agent.clone(model=model)
18441844

1845-
first_response = get_model_response(
1845+
mcp_response = get_model_response(
18461846
Response(
18471847
id="resp_mcp_123",
18481848
output=[
@@ -1876,7 +1876,7 @@ async def test_mcp_tool_execution_spans(
18761876
)
18771877
)
18781878

1879-
second_response = get_model_response(
1879+
final_response = get_model_response(
18801880
Response(
18811881
id="resp_final_123",
18821882
output=[
@@ -1917,7 +1917,7 @@ async def test_mcp_tool_execution_spans(
19171917
with patch.object(
19181918
agent.model._client._client,
19191919
"send",
1920-
side_effect=[first_response, second_response],
1920+
side_effect=[mcp_response, final_response],
19211921
) as _:
19221922
sentry_init(
19231923
integrations=[OpenAIAgentsIntegration()],
@@ -1972,7 +1972,7 @@ async def test_mcp_tool_execution_with_error(
19721972
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
19731973
agent = test_agent.clone(model=model)
19741974

1975-
first_response = get_model_response(
1975+
mcp_call_with_error_response = get_model_response(
19761976
Response(
19771977
id="resp_mcp_123",
19781978
output=[
@@ -2006,7 +2006,7 @@ async def test_mcp_tool_execution_with_error(
20062006
)
20072007
)
20082008

2009-
second_response = get_model_response(
2009+
final_response = get_model_response(
20102010
Response(
20112011
id="resp_final_123",
20122012
output=[
@@ -2047,7 +2047,7 @@ async def test_mcp_tool_execution_with_error(
20472047
with patch.object(
20482048
agent.model._client._client,
20492049
"send",
2050-
side_effect=[first_response, second_response],
2050+
side_effect=[mcp_call_with_error_response, final_response],
20512051
) as _:
20522052
sentry_init(
20532053
integrations=[OpenAIAgentsIntegration()],
@@ -2100,7 +2100,7 @@ async def test_mcp_tool_execution_without_pii(
21002100
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
21012101
agent = test_agent.clone(model=model)
21022102

2103-
first_response = get_model_response(
2103+
mcp_response = get_model_response(
21042104
Response(
21052105
id="resp_mcp_123",
21062106
output=[
@@ -2134,7 +2134,7 @@ async def test_mcp_tool_execution_without_pii(
21342134
)
21352135
)
21362136

2137-
second_response = get_model_response(
2137+
final_response = get_model_response(
21382138
Response(
21392139
id="resp_final_123",
21402140
output=[
@@ -2175,7 +2175,7 @@ async def test_mcp_tool_execution_without_pii(
21752175
with patch.object(
21762176
agent.model._client._client,
21772177
"send",
2178-
side_effect=[first_response, second_response],
2178+
side_effect=[mcp_response, final_response],
21792179
) as _:
21802180
sentry_init(
21812181
integrations=[OpenAIAgentsIntegration()],
@@ -2324,7 +2324,7 @@ def failing_tool(message: str) -> str:
23242324
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
23252325
agent_with_tool = test_agent.clone(tools=[failing_tool], model=model)
23262326

2327-
first_response = get_model_response(
2327+
tool_response = get_model_response(
23282328
Response(
23292329
id="resp_1",
23302330
output=[
@@ -2356,7 +2356,7 @@ def failing_tool(message: str) -> str:
23562356
)
23572357
)
23582358

2359-
second_response = get_model_response(
2359+
final_response = get_model_response(
23602360
Response(
23612361
id="resp_2",
23622362
output=[
@@ -2397,7 +2397,7 @@ def failing_tool(message: str) -> str:
23972397
with patch.object(
23982398
agent_with_tool.model._client._client,
23992399
"send",
2400-
side_effect=[first_response, second_response],
2400+
side_effect=[tool_response, final_response],
24012401
) as _:
24022402
sentry_init(
24032403
integrations=[OpenAIAgentsIntegration()],
@@ -2665,7 +2665,7 @@ def calculator(a: int, b: int) -> int:
26652665
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
26662666
agent_with_tool = test_agent.clone(tools=[calculator], model=model)
26672667

2668-
first_response = get_model_response(
2668+
tool_call_response = get_model_response(
26692669
Response(
26702670
id="resp_1",
26712671
output=[
@@ -2697,7 +2697,7 @@ def calculator(a: int, b: int) -> int:
26972697
)
26982698
)
26992699

2700-
second_response = get_model_response(
2700+
final_response = get_model_response(
27012701
Response(
27022702
id="resp_2",
27032703
output=[
@@ -2738,7 +2738,7 @@ def calculator(a: int, b: int) -> int:
27382738
with patch.object(
27392739
agent_with_tool.model._client._client,
27402740
"send",
2741-
side_effect=[first_response, second_response],
2741+
side_effect=[tool_call_response, final_response],
27422742
) as _:
27432743
sentry_init(
27442744
integrations=[OpenAIAgentsIntegration()],
@@ -3260,7 +3260,7 @@ def simple_tool(message: str) -> str:
32603260
model = OpenAIResponsesModel(model="gpt-4", openai_client=client)
32613261
agent_with_tool = test_agent.clone(tools=[simple_tool], model=model)
32623262

3263-
first_response = get_model_response(
3263+
tool_response = get_model_response(
32643264
Response(
32653265
id="call_123",
32663266
output=[
@@ -3292,7 +3292,7 @@ def simple_tool(message: str) -> str:
32923292
)
32933293
)
32943294

3295-
second_response = get_model_response(
3295+
final_response = get_model_response(
32963296
Response(
32973297
id="resp_final_789",
32983298
output=[
@@ -3333,7 +3333,7 @@ def simple_tool(message: str) -> str:
33333333
with patch.object(
33343334
agent_with_tool.model._client._client,
33353335
"send",
3336-
side_effect=[first_response, second_response],
3336+
side_effect=[tool_response, final_response],
33373337
) as _:
33383338
sentry_init(
33393339
integrations=[OpenAIAgentsIntegration()],

0 commit comments

Comments
 (0)