Skip to content

Commit 94d848c

Browse files
fix(langchain): Record run_name as gen_ai.function_id for text completions
1 parent a9d5e15 commit 94d848c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sentry_sdk/integrations/langchain.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ def on_llm_start(
348348

349349
pipeline_name = kwargs.get("name")
350350
if pipeline_name:
351-
span.set_data(SPANDATA.GEN_AI_PIPELINE_NAME, pipeline_name)
351+
span.set_data(SPANDATA.GEN_AI_FUNCTION_ID, pipeline_name)
352352

353353
if model:
354354
span.set_data(

tests/integrations/langchain/test_langchain.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ def test_langchain_text_completion(
155155
llm_span = llm_spans[0]
156156
assert llm_span["description"] == "text_completion gpt-3.5-turbo"
157157
assert llm_span["data"]["gen_ai.system"] == "openai"
158-
assert llm_span["data"]["gen_ai.pipeline.name"] == "my-snazzy-pipeline"
158+
assert llm_span["data"]["gen_ai.function_id"] == "my-snazzy-pipeline"
159159
assert llm_span["data"]["gen_ai.request.model"] == "gpt-3.5-turbo"
160160
assert llm_span["data"]["gen_ai.response.text"] == "The capital of France is Paris."
161161
assert llm_span["data"]["gen_ai.usage.total_tokens"] == 25
@@ -1859,7 +1859,7 @@ def test_langchain_message_truncation(sentry_init, capture_events):
18591859

18601860
llm_span = llm_spans[0]
18611861
assert llm_span["data"]["gen_ai.operation.name"] == "text_completion"
1862-
assert llm_span["data"][SPANDATA.GEN_AI_PIPELINE_NAME] == "my_pipeline"
1862+
assert llm_span["data"][SPANDATA.GEN_AI_FUNCTION_ID] == "my_pipeline"
18631863

18641864
assert SPANDATA.GEN_AI_REQUEST_MESSAGES in llm_span["data"]
18651865
messages_data = llm_span["data"][SPANDATA.GEN_AI_REQUEST_MESSAGES]

0 commit comments

Comments
 (0)