dont hardcode streaming parameter

Author: shellmayr

sentry_sdk/integrations/cohere.py

@@ -178,7 +178,7 @@ def new_chat(*args: "Any", **kwargs: "Any") -> "Any":
             for k, v in COLLECTED_CHAT_PARAMS.items():
                 if k in kwargs:
                     set_data_normalized(span, v, kwargs[k])
-            set_data_normalized(span, SPANDATA.GEN_AI_RESPONSE_STREAMING, False)
+            set_data_normalized(span, SPANDATA.GEN_AI_RESPONSE_STREAMING, streaming)
 
             if streaming:
                 old_iterator = res

tests/integrations/cohere/test_cohere.py

@@ -72,6 +72,7 @@ def test_nonstreaming_chat(
         assert SPANDATA.GEN_AI_REQUEST_MESSAGES not in span["data"]
         assert SPANDATA.GEN_AI_RESPONSE_TEXT not in span["data"]
 
+    assert span["data"][SPANDATA.GEN_AI_RESPONSE_STREAMING] is False
     assert span["data"]["gen_ai.usage.output_tokens"] == 10
     assert span["data"]["gen_ai.usage.input_tokens"] == 20
     assert span["data"]["gen_ai.usage.total_tokens"] == 30
@@ -151,6 +152,7 @@ def test_streaming_chat(sentry_init, capture_events, send_default_pii, include_p
         assert SPANDATA.GEN_AI_REQUEST_MESSAGES not in span["data"]
         assert SPANDATA.GEN_AI_RESPONSE_TEXT not in span["data"]
 
+    assert span["data"][SPANDATA.GEN_AI_RESPONSE_STREAMING] is True
     assert span["data"]["gen_ai.usage.output_tokens"] == 10
     assert span["data"]["gen_ai.usage.input_tokens"] == 20
     assert span["data"]["gen_ai.usage.total_tokens"] == 30