Skip to content

Commit e93fd1b

Browse files
committed
.
1 parent b270e5a commit e93fd1b

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

tests/integrations/asgi/test_asgi.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -166,19 +166,17 @@ def test_invalid_transaction_style(asgi3_app):
166166

167167
@pytest.mark.asyncio
168168
@pytest.mark.parametrize(
169-
("span_streaming", "send_default_pii"),
170-
[[False, True], [False, True]],
169+
("span_streaming"),
170+
(True, False),
171171
)
172172
async def test_capture_transaction(
173173
sentry_init,
174174
asgi3_app,
175175
capture_events,
176176
capture_envelopes,
177177
span_streaming,
178-
send_default_pii,
179178
):
180179
sentry_init(
181-
send_default_pii=send_default_pii,
182180
traces_sample_rate=1.0,
183181
_experiments={
184182
"trace_lifecycle": "stream" if span_streaming else "static",
@@ -206,15 +204,10 @@ async def test_capture_transaction(
206204
assert span["attributes"]["sentry.span.source"] == "url"
207205
assert span["attributes"]["sentry.op"] == "http.server"
208206

209-
if send_default_pii:
210-
assert span["attributes"]["client.address"] == "127.0.0.1"
211-
else:
212-
assert "client.address" not in span["attributes"]
213-
214-
assert span["attributes"]["http.request.method"] == "GET"
215207
assert span["attributes"]["url.full"] == "http://localhost/some_url"
208+
assert span["attributes"]["network.protocol.name"] == "http"
209+
assert span["attributes"]["http.request.method"] == "GET"
216210
assert span["attributes"]["http.query"] == "somevalue=123"
217-
assert span["attributes"]["http.request.protocol.name"] == "http"
218211
assert span["attributes"]["http.request.header.host"] == "localhost"
219212
assert span["attributes"]["http.request.header.remote-addr"] == "127.0.0.1"
220213
assert (

0 commit comments

Comments
 (0)