ref(wsgi): Update _werkzeug vendor to newer version#4793
ref(wsgi): Update _werkzeug vendor to newer version#4793mgaligniana wants to merge 2 commits intogetsentry:masterfrom
Conversation
75b9810 to
dab33fb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4793 +/- ##
==========================================
- Coverage 84.47% 83.41% -1.07%
==========================================
Files 158 158
Lines 16506 16512 +6
Branches 2865 2864 -1
==========================================
- Hits 13944 13773 -171
- Misses 1712 1889 +177
Partials 850 850
|
ba2c350 to
6238c21
Compare
|
Thanks for the PR @mgaligniana -- I think the |
6238c21 to
b4ee7ae
Compare
|
Ok, Seer 🎉 liked! But codecov not, should I add new tests for the new vendor? Edited: I think yes because Anton said:
But do you think I should copy-paste the test from werkzeug to get_host for example? |
Tests would be great. I think the one you linked would be good, plus something custom for the |
2b7f7f1 to
71d1151
Compare
145a66a to
327eefe
Compare
327eefe to
3da87d1
Compare
3da87d1 to
976b868
Compare
|
Hi @sentrivana, just following up on this! In case you need any changes from my side! Thank you! |
|
Hey @mgaligniana, sorry for dropping the ball on this, I'll get to reviewing eventually -- no need for you to wait though, I can just apply any changes myself. Thanks for your work! |
|
Perfect, no problem!! Thank you!! |
976b868 to
a24aae1
Compare
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
|
Hey, I'm sorry but I'll close this PR after all. It's drifted from master a lot (which is my fault), and I'm also a bit concerned about refactoring this code just for the sake of refactoring it (this is also our fault for making the issue in the first place), since it seems to have been working fine until now. |
|
Don't worry @sentrivana and thanks for the explanation! I hope I can get another ticket! 🚀 |


Fixes GH-3516