Skip to content

feat(pydantic-ai): Add tool description to execute_tool spans #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 27 commits into from
Mar 9, 2026
+59 −3

Address CR comments

46743ae
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(pydantic-ai): Add tool description to execute_tool spans #5596

Address CR comments
46743ae
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: code-review completed Mar 6, 2026 in 2m 19s

1 issue

code-review: Found 1 issue (1 high)

High

NameError: execute_tool_span is used but no longer imported - `tests/integrations/pydantic_ai/test_pydantic_ai.py:2482-2483`

The import of execute_tool_span was removed from the import statement, but line 2493 still calls execute_tool_span("test_tool", {"arg": "value"}, None, "function"). This will cause a NameError: name 'execute_tool_span' is not defined at runtime when the test executes.

Duration: 2m 17s · Tokens: 624.7k in / 7.7k out · Cost: $1.03 (+extraction: $0.00, +fix_gate: $0.00)

Annotations

Check failure on line 2483 in tests/integrations/pydantic_ai/test_pydantic_ai.py

See this annotation in the file changed.

@github-actions github-actions / warden: code-review

NameError: execute_tool_span is used but no longer imported 

The import of `execute_tool_span` was removed from the import statement, but line 2493 still calls `execute_tool_span("test_tool", {"arg": "value"}, None, "function")`. This will cause a `NameError: name 'execute_tool_span' is not defined` at runtime when the test executes.
View more details on GitHub Actions