feat(pydantic-ai): Add tool description to execute_tool spans #5596
2 issues
find-bugs: Found 2 issues (1 high, 1 low)
High
Test will fail with NameError due to missing execute_tool_span import - `tests/integrations/pydantic_ai/test_pydantic_ai.py:2482-2483`
The diff removes the import of execute_tool_span from the import statement, but line 2493 still uses execute_tool_span("test_tool", {"arg": "value"}, None, "function"). This will cause a NameError: name 'execute_tool_span' is not defined when the test test_update_execute_tool_span_with_none_result runs.
Low
Unused ToolDefinition import adds unnecessary dependency - `tests/integrations/pydantic_ai/test_pydantic_ai.py:21`
The import from pydantic_ai._tool_manager import ToolDefinition at line 21 is never used in the test file. Searching the entire file confirms ToolDefinition only appears on the import line. While not a security issue, this adds an unnecessary dependency on a private pydantic-ai module that could break if the internal API changes.
Duration: 2m 53s · Tokens: 624.6k in / 10.7k out · Cost: $1.25 (+merge: $0.00, +fix_gate: $0.01)
Annotations
Check failure on line 2483 in tests/integrations/pydantic_ai/test_pydantic_ai.py
github-actions / warden: find-bugs
Test will fail with NameError due to missing execute_tool_span import
The diff removes the import of `execute_tool_span` from the import statement, but line 2493 still uses `execute_tool_span("test_tool", {"arg": "value"}, None, "function")`. This will cause a `NameError: name 'execute_tool_span' is not defined` when the test `test_update_execute_tool_span_with_none_result` runs.