Skip to content

ref: Add _is_segment() to streaming spans (12) #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 85 commits into from
Mar 11, 2026

Merge branch 'master' into ivana/span-first-12-is-segment

62dba9b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

ref: Add _is_segment() to streaming spans (12) #5619

Merge branch 'master' into ivana/span-first-12-is-segment
62dba9b
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: code-review completed Mar 11, 2026 in 1m 16s

1 issue

code-review: Found 1 issue (1 medium)

Medium

Missing test coverage for _is_segment() method in NoOpStreamedSpan - `sentry_sdk/traces.py:539-540`

The new _is_segment() method in NoOpStreamedSpan lacks unit test coverage. This method is used in _span_batcher.py to serialize spans for transport. Tests should verify that _is_segment() returns True when a scope is provided and False when scope is None.

Duration: 1m 16s · Tokens: 304.9k in / 4.6k out · Cost: $0.50

Annotations

Check warning on line 540 in sentry_sdk/traces.py

See this annotation in the file changed.

@github-actions github-actions / warden: code-review

Missing test coverage for _is_segment() method in NoOpStreamedSpan 

The new `_is_segment()` method in `NoOpStreamedSpan` lacks unit test coverage. This method is used in `_span_batcher.py` to serialize spans for transport. Tests should verify that `_is_segment()` returns `True` when a scope is provided and `False` when scope is `None`.
View more details on GitHub Actions