Skip to content

ref(rust): Don't implement separate scope management #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 8 commits into from
Mar 12, 2026

.

0bf02b4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

ref(rust): Don't implement separate scope management #5639

.
0bf02b4
Select commit
Loading
Failed to load commit list.
GitHub Actions / warden: code-review completed Mar 11, 2026 in 1m 6s

1 issue

code-review: Found 1 issue (1 high)

High

sentry_span.__exit__() called without required arguments causes TypeError - `sentry_sdk/integrations/rust_tracing.py:226`

The __exit__() method is called without arguments, but Python's context manager protocol requires three arguments (exc_type, exc_value, traceback). The Span.__exit__ method signature is def __exit__(self, ty, value, tb) with no default values. This will raise TypeError: __exit__() missing 3 required positional arguments when on_close() is called.

Duration: 1m 3s · Tokens: 152.5k in / 2.0k out · Cost: $0.27 (+fix_gate: $0.00)

Annotations

Check failure on line 226 in sentry_sdk/integrations/rust_tracing.py

See this annotation in the file changed.

@github-actions github-actions / warden: code-review

sentry_span.__exit__() called without required arguments causes TypeError 

The `__exit__()` method is called without arguments, but Python's context manager protocol requires three arguments (`exc_type`, `exc_value`, `traceback`). The `Span.__exit__` method signature is `def __exit__(self, ty, value, tb)` with no default values. This will raise `TypeError: __exit__() missing 3 required positional arguments` when `on_close()` is called.
View more details on GitHub Actions