Skip to content

fix(anthropic): Close span on GeneratorExit #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 32 commits into from
Mar 13, 2026
+96 −97

keep comment

f36dd5d
Select commit
Loading
Failed to load commit list.
Merged

fix(anthropic): Close span on GeneratorExit #5643

keep comment
f36dd5d
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Mar 13, 2026 in 51s

1 issue

code-review: Found 1 issue (1 medium)

Medium

Missing test coverage for GeneratorExit handling - `sentry_sdk/integrations/anthropic.py:374-420`

The PR adds try/finally blocks to close spans when generators are suspended via GeneratorExit, but no tests verify this behavior. Without tests, there's no validation that spans are correctly closed with partial data when a consumer abandons the iterator early. Test coverage should verify the span is closed and contains expected partial data.

Duration: 50.5s · Tokens: 130.5k in / 1.8k out · Cost: $0.17

Annotations

Check warning on line 420 in sentry_sdk/integrations/anthropic.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

Missing test coverage for GeneratorExit handling 

The PR adds `try/finally` blocks to close spans when generators are suspended via `GeneratorExit`, but no tests verify this behavior. Without tests, there's no validation that spans are correctly closed with partial data when a consumer abandons the iterator early. Test coverage should verify the span is closed and contains expected partial data.
View more details on @sentry/warden