test(langchain): Add text completion test #5740
1 issue
code-review: Found 1 issue (1 medium)
Medium
Deleted test for langchain-core-only installations has no replacement - `tests/integrations/langchain/test_langchain.py:1093-1098`
The removed test_langchain_integration_with_langchain_core_only test validated a specific edge case: the integration working when langchain.agents.AgentExecutor is unavailable but langchain-core is installed. The new test_langchain_text_completion test uses the full langchain library flow but doesn't cover this compatibility scenario. Users who only install langchain-core without the full langchain package may not have regression test coverage.
Duration: 2m 24s · Tokens: 433.1k in / 5.3k out · Cost: $0.83 (+extraction: $0.00)
Annotations
Check warning on line 1098 in tests/integrations/langchain/test_langchain.py
sentry-warden / warden: code-review
Deleted test for langchain-core-only installations has no replacement
The removed `test_langchain_integration_with_langchain_core_only` test validated a specific edge case: the integration working when `langchain.agents.AgentExecutor` is unavailable but `langchain-core` is installed. The new `test_langchain_text_completion` test uses the full langchain library flow but doesn't cover this compatibility scenario. Users who only install `langchain-core` without the full `langchain` package may not have regression test coverage.