clean up experimental otel references#5893
Conversation
|
This PR has been automatically converted to draft. All PRs must start as drafts per our contributing guidelines. Next steps:
|
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Langchain
Bug Fixes 🐛Ci
Openai
Other
Documentation 📚
Internal Changes 🔧Langchain
Openai
Other
Other
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "record_sql_params": Optional[bool], | ||
| "continuous_profiling_auto_start": Optional[bool], | ||
| "continuous_profiling_mode": Optional[ContinuousProfilerMode], | ||
| "otel_powered_performance": Optional[bool], |
There was a problem hiding this comment.
Removed experiment flag still used in client.py
High Severity
The otel_powered_performance key was removed from the Experiments TypedDict, but client.py still checks self.options["_experiments"].get("otel_powered_performance", False) to enable OTel-powered performance and add OpenTelemetryIntegration to default integrations. This is an incomplete cleanup — the runtime code in client.py (and corresponding tests in test_experimental.py) still depends on the removed flag, leaving an inconsistent state. If OTel is no longer experimental, the gating logic in client.py also needs to be updated to reflect the new way OTel gets enabled.
otel support is no longer experimental, clean up the warnings and the experiment flag from consts fixes getsentry#5028
f16a317 to
73e3163
Compare
|
This PR has been closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |


remove experimental warnings and labels from traces.py and the otel integration, and drop the otel_powered_performance experiment flag from consts since otel support is no longer experimental
fixes #5028