Skip to content

clean up experimental otel references#5893

Closed
knQzx wants to merge 1 commit intogetsentry:masterfrom
knQzx:fix/cleanup-experimental-otel
Closed

clean up experimental otel references#5893
knQzx wants to merge 1 commit intogetsentry:masterfrom
knQzx:fix/cleanup-experimental-otel

Conversation

@knQzx
Copy link
Copy Markdown

@knQzx knQzx commented Mar 26, 2026

remove experimental warnings and labels from traces.py and the otel integration, and drop the otel_powered_performance experiment flag from consts since otel support is no longer experimental

fixes #5028

@knQzx knQzx requested a review from a team as a code owner March 26, 2026 22:02
@github-actions github-actions bot marked this pull request as draft March 26, 2026 22:02
@sdk-maintainer-bot sdk-maintainer-bot bot added the converted-to-draft Used for automated contribution checks. label Mar 26, 2026
@sdk-maintainer-bot
Copy link
Copy Markdown

This PR has been automatically converted to draft. All PRs must start as drafts per our contributing guidelines.

Next steps:

  1. Ensure CI passes
  2. Fill in the PR description completely
  3. Mark as "Ready for review" when you're done

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Langchain

  • Set gen_ai.operation.name and gen_ai.pipeline.name on LLM spans by ericapisani in #5849
  • Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani in #5707
  • Update LLM span operation to gen_ai.generate_text by ericapisani in #5796

Bug Fixes 🐛

Ci

  • Use gh CLI to convert PR to draft by stephanie-anderson in #5874
  • Use GitHub App token for draft PR enforcement by stephanie-anderson in #5871

Openai

  • Always set gen_ai.response.streaming for Responses by alexander-alderman-webb in #5697
  • Simplify Responses input handling by alexander-alderman-webb in #5695
  • Use max_output_tokens for Responses API by alexander-alderman-webb in #5693
  • Always set gen_ai.response.streaming for Completions by alexander-alderman-webb in #5692
  • Simplify Completions input handling by alexander-alderman-webb in #5690
  • Simplify embeddings input handling by alexander-alderman-webb in #5688

Other

  • (google-genai) Guard response extraction by alexander-alderman-webb in #5869
  • (workflow) Fix permission issue with github app and PR draft graphql endpoint by Jeffreyhung in #5887

Documentation 📚

  • Update CONTRIBUTING.md with contribution requirements and TOC by stephanie-anderson in #5896

Internal Changes 🔧

Langchain

  • Add text completion test by alexander-alderman-webb in #5740
  • Add tool execution test by alexander-alderman-webb in #5739
  • Add basic agent test with Responses call by alexander-alderman-webb in #5726
  • Replace mocks with httpx types by alexander-alderman-webb in #5724
  • Consolidate span origin assertion by alexander-alderman-webb in #5723
  • Consolidate available tools assertion by alexander-alderman-webb in #5721

Openai

  • Replace mocks with httpx types for streaming Responses by alexander-alderman-webb in #5882
  • Replace mocks with httpx types for streaming Completions by alexander-alderman-webb in #5879
  • Move input handling code into API-specific functions by alexander-alderman-webb in #5687

Other

  • (ai) Rename generate_text to text_completion by ericapisani in #5885
  • (asyncpg) Normalize query whitespace in integration by ericapisani in #5855
  • Add workflow to close unvetted non-maintainer PRs by stephanie-anderson in #5895
  • Exclude compromised litellm versions by alexander-alderman-webb in #5876
  • Reactivate litellm tests by alexander-alderman-webb in #5853
  • Add note to coordinate with assignee before PR submission by sentrivana in #5868
  • Temporarily stop running litellm tests by alexander-alderman-webb in #5851

Other

  • clean up experimental otel references by knQzx in #5893
  • ci+docs: Add draft PR enforcement by stephanie-anderson in #5867

🤖 This preview updates automatically when you update the PR.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

"record_sql_params": Optional[bool],
"continuous_profiling_auto_start": Optional[bool],
"continuous_profiling_mode": Optional[ContinuousProfilerMode],
"otel_powered_performance": Optional[bool],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed experiment flag still used in client.py

High Severity

The otel_powered_performance key was removed from the Experiments TypedDict, but client.py still checks self.options["_experiments"].get("otel_powered_performance", False) to enable OTel-powered performance and add OpenTelemetryIntegration to default integrations. This is an incomplete cleanup — the runtime code in client.py (and corresponding tests in test_experimental.py) still depends on the removed flag, leaving an inconsistent state. If OTel is no longer experimental, the gating logic in client.py also needs to be updated to reflect the new way OTel gets enabled.

Fix in Cursor Fix in Web

otel support is no longer experimental, clean up the warnings
and the experiment flag from consts

fixes getsentry#5028
@knQzx knQzx force-pushed the fix/cleanup-experimental-otel branch from f16a317 to 73e3163 Compare March 26, 2026 22:19
@stephanie-anderson stephanie-anderson added the violating-contribution-guidelines Used for automated community contribution checks. label Mar 27, 2026
@stephanie-anderson
Copy link
Copy Markdown
Contributor

This PR has been closed. The referenced issue does not show a discussion between you and a maintainer.

To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR.

Please review our contributing guidelines for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-maintainer-discussion Used for automated community contribution checks. violating-contribution-guidelines Used for automated community contribution checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up experimental (P)OTel stuff

2 participants