Skip to content

feat(celery): Support span streaming #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 18 commits into from
Apr 21, 2026

fix source and txn name

71a6728
Select commit
Loading
Failed to load commit list.
Merged

feat(celery): Support span streaming #6074

fix source and txn name
71a6728
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Apr 15, 2026 in 6m 34s

1 issue

code-review: Found 1 issue (1 high)

High

_is_segment method accessed as property, always evaluates to truthy - `sentry_sdk/scope.py:901`

span._is_segment is a method that returns a boolean, but it's being accessed without parentheses on line 901. This means it evaluates to a bound method object, which is always truthy. As a result, all StreamedSpan instances will be treated as segments, incorrectly setting _transaction and _transaction_info for non-segment spans.

Duration: 6m 31s · Tokens: 1.8M in / 21.9k out · Cost: $2.78 (+extraction: $0.00, +fix_gate: $0.00)

Annotations

Check failure on line 901 in sentry_sdk/scope.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

_is_segment method accessed as property, always evaluates to truthy 

`span._is_segment` is a method that returns a boolean, but it's being accessed without parentheses on line 901. This means it evaluates to a bound method object, which is always truthy. As a result, all `StreamedSpan` instances will be treated as segments, incorrectly setting `_transaction` and `_transaction_info` for non-segment spans.
View more details on @sentry/warden