The PR introduces significant new functionality for span streaming support but the PR description explicitly indicates tests have not been added yet. This includes conditional logic for streaming spans in both patch_redis_pipeline and patch_redis_client functions. Without tests, regressions could occur when the streaming path is exercised.

In _set_pipeline_data, when the span is a StreamedSpan, the function builds the commands list (iterating through commands_seq) but never sets any attributes on the span. The is_cluster and is_transaction tags are skipped, and the redis.commands data is never converted to attributes. This results in pipeline spans with streaming enabled having no useful metadata, while regular Span instances retain all this information.

In _sentry_execute_command, spans are entered manually via __enter__() but if await old_execute_command() raises an exception (e.g., connection error, timeout), neither db_span.__exit__() nor cache_span.__exit__() are called. This causes spans to never be closed/sent, leading to incorrect timing data and potential memory leaks. The code should use try/finally or context managers to ensure proper cleanup.

Also found at:

• sentry_sdk/integrations/redis/_sync_common.py:151-152

The async version of _sentry_execute_command does not wrap set_db_data_fn(), _set_client_data(), and _set_cache_data() calls with capture_internal_exceptions(), unlike the sync version in _sync_common.py. If these functions throw an exception (e.g., due to unexpected Redis client state), it could propagate to the user's code instead of being handled internally. This inconsistency could cause unexpected failures in async Redis operations.

The SPANDATA.DB_DRIVER_NAME attribute is set to different values depending on span type: "redis" for StreamedSpan (line 55) vs "redis-py" for Span (line 68). This inconsistency appears to be unintentional since both branches should report the same driver name. This could cause confusion in Sentry dashboards when comparing spans from different modes, as they would show different driver names for the same underlying Redis client.

In _set_pipeline_data, when the span is a StreamedSpan, the code builds the commands list (lines 119-125) but never sets any attributes on the span. The redis.is_cluster, redis.transaction tags and redis.commands data are all skipped for streamed spans, meaning this computed data is completely discarded. This causes loss of observability data for users in span streaming mode.

Also found at:

• sentry_sdk/integrations/redis/utils.py:140-147