feat(redis): Support streaming spans #6083
1 issue
code-review: Found 1 issue (1 medium)
Medium
Test assertion checks wrong span index - `tests/integrations/redis/test_redis_cache_module_async.py:301`
Line 301 asserts "cache.hit" not in spans[1]["data"] but the surrounding context is testing spans[2] (the cache.put span). This is likely a copy-paste error. The assertion passes trivially because spans[1] is a db.redis span which never has cache.hit, meaning the actual cache.put span (spans[2]) is not being verified for the absence of cache.hit.
Also found at:
tests/integrations/redis/test_redis_cache_module.py:331
Duration: 6m 45s · Tokens: 3.1M in / 34.6k out · Cost: $4.59 (+extraction: $0.01, +merge: $0.00)
Annotations
Check warning on line 301 in tests/integrations/redis/test_redis_cache_module_async.py
sentry-warden / warden: code-review
Test assertion checks wrong span index
Line 301 asserts `"cache.hit" not in spans[1]["data"]` but the surrounding context is testing `spans[2]` (the cache.put span). This is likely a copy-paste error. The assertion passes trivially because `spans[1]` is a db.redis span which never has cache.hit, meaning the actual cache.put span (`spans[2]`) is not being verified for the absence of cache.hit.
Check warning on line 331 in tests/integrations/redis/test_redis_cache_module.py
sentry-warden / warden: code-review
[2KU-YZX] Test assertion checks wrong span index (additional location)
Line 301 asserts `"cache.hit" not in spans[1]["data"]` but the surrounding context is testing `spans[2]` (the cache.put span). This is likely a copy-paste error. The assertion passes trivially because `spans[1]` is a db.redis span which never has cache.hit, meaning the actual cache.put span (`spans[2]`) is not being verified for the absence of cache.hit.