feat(sqlalchemy): Support span streaming#6132
Merged
alexander-alderman-webb merged 25 commits intomasterfrom Apr 29, 2026
Merged
feat(sqlalchemy): Support span streaming#6132alexander-alderman-webb merged 25 commits intomasterfrom
alexander-alderman-webb merged 25 commits intomasterfrom
Conversation
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.43s All tests are passing successfully. ❌ Patch coverage is 9.23%. Project has 14865 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
sentrivana
requested changes
Apr 27, 2026
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
Looking great overall! Just not sure about a handful of attributes.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5efa060. Configure here.
sentrivana
approved these changes
Apr 28, 2026
Contributor
sentrivana
left a comment
There was a problem hiding this comment.
See https://github.com/getsentry/sentry-python/pull/6132/changes#r3154376220, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adapt
add_query_source()analogously to changes toadd_http_request_source()in #6084.Add
record_sql_queries_supporting_streaming()based onrecord_sql_queries()so that the streaming path is not triggered for other ORM integrations until they support the streaming trace lifecycle. Once the last ORM integration supports span-streaming the functions can be de-duplicated.Set
<unknown SQL query>as the name when the description was previouslyNone.Adapting Tests
sedcommands used for converting transaction context managers:sedcommands used for converting code source attributes:sedcommands used for converting event capture:sedcommands used for convertingop:sedcommands used for convertingdescription:sedcommands used for convertingdatatoattributes:sedcommands used for converting timestamps:Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)