feat(core): Introduce @sentry/expo-upload-sourcemaps package (#6027)

* feat(core): Introduce @sentry/expo-upload-sourcemaps package

Moves the Expo sourcemap upload script into a new scoped workspace
package @sentry/expo-upload-sourcemaps and replaces the original
scripts/expo-upload-sourcemaps.js in @sentry/react-native with a shim
that forwards to it.

The existing sentry-expo-upload-sourcemaps bin in @sentry/react-native
keeps working unchanged, so projects with the bin referenced in
package.json scripts or invoked via npx are not affected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(core): Add CHANGELOG entry for @sentry/expo-upload-sourcemaps package

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Update changelog

* docs(core): Soften CHANGELOG wording for superseded sentry-expo-upload-sourcemaps bin

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(core): Address Warden review findings in expo-upload-sourcemaps CLI

- Drop the callback passed to fs.writeFileSync. writeFileSync is
  synchronous and silently discards the callback argument; the error
  branch never fired and the success log never printed.
- Preserve a non-zero exit code when sentry-cli is terminated by a
  signal. spawnSync returns result.status === null in that case, and
  process.exit(null) coerces to 0, previously reporting success after
  an aborted upload.

Both issues were inherited verbatim from the script's prior location
inside @sentry/react-native. Fixed now that the script has moved to
its own package.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(core): Use bash script for @sentry/expo-upload-sourcemaps build:tarball

Yarn 3's built-in shell errors on unmatched globs, so the inlined
"rm -f *.tgz && npm pack" fails in CI where no prior tarball exists.
Match packages/core's pattern and run through real bash via a script
file.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(core): Include @sentry/expo-upload-sourcemaps in TypeScript 3.8 type check

Yalc rewrites the workspace:* dep to 8.8.0 when publishing @sentry/react-native,
so ts3.8-test's yarn install tries to fetch @sentry/expo-upload-sourcemaps@8.8.0
from the npm registry before the package is published and fails with 404.

Publish and yalc-add the new package alongside @sentry/react-native, and pin
the transitive dep to the same local file reference via resolutions so yarn
doesn't try to resolve it from the registry.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(core): Include @sentry/expo-upload-sourcemaps in e2e sample app setup

The e2e CLI (dev-packages/e2e-tests/cli.mjs) yalc-publishes @sentry/react-native
and yalc-adds it into each matrix RN app. Yalc rewrites the workspace:* dep to
a concrete 8.8.0, so yarn install in the sample app tries to fetch
@sentry/expo-upload-sourcemaps@8.8.0 from the npm registry and 404s.

Mirror the fix applied to the TypeScript 3.8 type check: also yalc-publish the
new package, yalc-add it in the sample, and pin the transitive dep to the file
reference via resolutions so yarn does not touch the registry.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Correct copyright date

* Make rm command stricter

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: antonis

.craft.yml

@@ -8,3 +8,5 @@ targets:
     sdks:
       npm:@sentry/react-native:
         includeNames: /^sentry-react-native-\d.*\.tgz$/
+      npm:@sentry/expo-upload-sourcemaps:
+        includeNames: /^sentry-expo-upload-sourcemaps-\d.*\.tgz$/

CHANGELOG.md

@@ -10,6 +10,8 @@
 
 ### Features
 
+- Add new `@sentry/expo-upload-sourcemaps` package for uploading JavaScript bundles and source maps from Expo builds to Sentry ([#6027](https://github.com/getsentry/sentry-react-native/pull/6027))
+  - The existing `sentry-expo-upload-sourcemaps` bin bundled with `@sentry/react-native` is superseded by the new package; it continues to work unchanged for now
 - Expose scope-level attributes API (`setAttribute`, `setAttributes`, `removeAttribute`) bridging to native SDKs ([#6009](https://github.com/getsentry/sentry-react-native/pull/6009))
 - Expose screenshot masking options (`screenshot.maskAllText`, `screenshot.maskAllImages`, `screenshot.maskedViewClasses`, `screenshot.unmaskedViewClasses`) for error screenshots ([#6007](https://github.com/getsentry/sentry-react-native/pull/6007))
 - Warn Expo users at Metro startup when prebuilt native projects are missing Sentry configuration ([#5984](https://github.com/getsentry/sentry-react-native/pull/5984))

dev-packages/e2e-tests/cli.mjs

@@ -55,6 +55,7 @@ const e2eTestPackageName = JSON.parse(fs.readFileSync(`${e2eDir}/package.json`,
 const patchScriptsDir = path.resolve(e2eDir, 'patch-scripts');
 const workspaceRootDir = path.resolve(__dirname, '../..');
 const corePackageDir = path.resolve(workspaceRootDir, 'packages/core');
+const expoUploadSourcemapsPackageDir = path.resolve(workspaceRootDir, 'packages/expo-upload-sourcemaps');
 const corePackageJson = JSON.parse(fs.readFileSync(`${corePackageDir}/package.json`, 'utf8'));
 const RNVersion = env.RN_VERSION ? env.RN_VERSION : corePackageJson.devDependencies['react-native'];
 const RNEngine = env.RN_ENGINE ? env.RN_ENGINE : 'hermes';
@@ -109,6 +110,7 @@ function patchBoostIfNeeded(rnVersion, patchScriptsDir) {
 if (actions.includes('create') || (env.CI === undefined && actions.includes('build'))) {
   execSync(`yarn build`, { stdio: 'inherit', cwd: workspaceRootDir, env: env });
   execSync(`yalc publish --private`, { stdio: 'inherit', cwd: e2eDir, env: env });
+  execSync(`yalc publish`, { stdio: 'inherit', cwd: expoUploadSourcemapsPackageDir, env: env });
   execSync(`yalc publish`, { stdio: 'inherit', cwd: corePackageDir, env: env });
 }
 
@@ -122,7 +124,14 @@ if (actions.includes('create')) {
 
   // Install dependencies
   // yalc add doesn't fail if the package is not found - it skips silently.
-  let yalcAddOutput = execSync(`yalc add @sentry/react-native`, { cwd: appDir, env: env, encoding: 'utf-8' });
+  let yalcAddOutput = execSync(`yalc add @sentry/expo-upload-sourcemaps`, { cwd: appDir, env: env, encoding: 'utf-8' });
+  if (!yalcAddOutput.match(/Package .* added ==>/)) {
+    console.error(yalcAddOutput);
+    process.exit(1);
+  } else {
+    console.log(yalcAddOutput.trim());
+  }
+  yalcAddOutput = execSync(`yalc add @sentry/react-native`, { cwd: appDir, env: env, encoding: 'utf-8' });
   if (!yalcAddOutput.match(/Package .* added ==>/)) {
     console.error(yalcAddOutput);
     process.exit(1);
@@ -137,6 +146,19 @@ if (actions.includes('create')) {
     console.log(yalcAddOutput.trim());
   }
 
+  // Force yarn to resolve the transitive @sentry/expo-upload-sourcemaps dep
+  // to the local yalc copy. Without this, yarn tries to fetch it from the
+  // npm registry (because yalc rewrites the workspace:* spec in core's
+  // published package.json to a concrete version) and 404s until the package
+  // is released.
+  const appPackageJsonPath = `${appDir}/package.json`;
+  const appPackageJson = JSON.parse(fs.readFileSync(appPackageJsonPath, 'utf-8'));
+  appPackageJson.resolutions = {
+    ...appPackageJson.resolutions,
+    '@sentry/expo-upload-sourcemaps': 'file:.yalc/@sentry/expo-upload-sourcemaps',
+  };
+  fs.writeFileSync(appPackageJsonPath, JSON.stringify(appPackageJson, null, 2) + '\n');
+
   // original yarnrc contains the exact yarn version which causes corepack to fail to install yarn v3
   fs.writeFileSync(`${appDir}/.yarnrc.yml`, 'nodeLinker: node-modules', { encoding: 'utf-8' });
   // yarn v3 won't install dependencies in a sub project without a yarn.lock file present

dev-packages/type-check/run-type-check.sh

@@ -4,18 +4,24 @@ set -ex
 
 __dirpath=$(dirname $(realpath "$0"))
 
+cd "${__dirpath}/../../packages/expo-upload-sourcemaps"
+
+yalc publish
+
 cd "${__dirpath}/../../packages/core"
 
 yalc publish
 
 cd "${__dirpath}/ts3.8-test"
 
-# Add yalc package (creates .yalc/ directory and updates package.json)
+# Add yalc packages (creates .yalc/ directory and updates package.json)
+yalc add @sentry/expo-upload-sourcemaps
 yalc add @sentry/react-native
 
 yarn install
 
-# Re-add yalc package to ensure it's in node_modules (yarn might have removed it)
+# Re-add yalc packages to ensure they are in node_modules (yarn might have removed them)
+yalc add @sentry/expo-upload-sourcemaps
 yalc add @sentry/react-native
 
 echo "Removing duplicate React types..."

dev-packages/type-check/ts3.8-test/package.json

@@ -14,8 +14,12 @@
     "typescript": "3.8.3"
   },
   "dependencies": {
+    "@sentry/expo-upload-sourcemaps": "file:.yalc/@sentry/expo-upload-sourcemaps",
     "@sentry/react-native": "file:.yalc/@sentry/react-native",
     "react": "17.0.2",
     "react-native": "0.65.3"
+  },
+  "resolutions": {
+    "@sentry/expo-upload-sourcemaps": "file:.yalc/@sentry/expo-upload-sourcemaps"
   }
 }

package.json

@@ -42,6 +42,7 @@
   },
   "workspaces": [
     "packages/core",
+    "packages/expo-upload-sourcemaps",
     "dev-packages/e2e-tests",
     "dev-packages/type-check",
     "dev-packages/utils",

packages/core/package.json

@@ -75,6 +75,7 @@
     "@sentry/browser": "10.49.0",
     "@sentry/cli": "3.4.0",
     "@sentry/core": "10.49.0",
+    "@sentry/expo-upload-sourcemaps": "workspace:*",
     "@sentry/react": "10.49.0",
     "@sentry/types": "10.49.0"
   },