Skip to content

Commit 1005db9

Browse files
antonisclaude
andcommitted
chore: Clean up remaining ESLint references across the repo
- Update dependabot.yml: replace typescript-eslint group with oxlint - Update VS Code extensions: replace vscode-eslint with oxlint extension - Update update-javascript.sh: remove @sentry-internal/eslint-config-sdk - Remove stale eslint-disable comments from sample apps - Update comments referencing ESLint in SDK source files - Downgrade react-hooks/exhaustive-deps to warn in sample configs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 6974836 commit 1005db9

14 files changed

Lines changed: 13 additions & 19 deletions

File tree

.github/dependabot.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ updates:
1313
react-native-deps:
1414
patterns:
1515
- '@react-native/*'
16-
typescript-eslint-deps:
16+
oxlint:
1717
patterns:
18-
- '@typescript-eslint/*'
18+
- 'oxlint'
1919
ignore:
2020
- dependency-name: '@sentry*'
2121
- package-ecosystem: gradle

.vscode/extensions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
// See http://go.microsoft.com/fwlink/?LinkId=827846
33
// for the documentation about the extensions.json format
4-
"recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"]
4+
"recommendations": ["esbenp.prettier-vscode", "nickelpack.oxlint"]
55
}

packages/core/.oxlintrc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
{ "argsIgnorePattern": "^_", "varsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_" }
1515
],
1616

17-
// === Base rules from eslint-config-sdk/base.js ===
17+
// === Base rules (ported from @sentry-internal/eslint-config-sdk) ===
1818
"no-console": "error",
1919
"no-alert": "error",
2020
"no-param-reassign": "error",
@@ -32,7 +32,7 @@
3232
"import/namespace": "off",
3333
"import/no-unresolved": "off",
3434

35-
// === Rules turned off (not enforced in ESLint or causing false positives) ===
35+
// === Rules turned off (not needed or causing false positives) ===
3636
"no-control-regex": "off",
3737
"jsdoc/check-tag-names": "off",
3838
"jsdoc/require-yields": "off",

packages/core/src/js/RNSentryReplayMaskNativeComponent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { HostComponent, ViewProps } from 'react-native';
2-
// The default export exists in the file but eslint doesn't see it
2+
// The default export exists in the file but the linter doesn't see it
33
import { codegenNativeComponent } from 'react-native';
44

55
// If changed to type NativeProps = ViewProps, react native codegen will fail finding the NativeProps type

packages/core/src/js/RNSentryReplayUnmaskNativeComponent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { HostComponent, ViewProps } from 'react-native';
2-
// The default export exists in the file but eslint doesn't see it
2+
// The default export exists in the file but the linter doesn't see it
33
import { codegenNativeComponent } from 'react-native';
44

55
// If changed to type NativeProps = ViewProps, react native codegen will fail finding the NativeProps type

packages/core/src/js/playground/modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ function openURLInBrowser(url: string): void {
423423
const devServer = getDevServer();
424424
if (devServer?.url) {
425425
// This doesn't work for Expo project with Web enabled
426-
// disable-next-line @typescript-eslint/no-floating-promises
426+
// oxlint-disable-next-line typescript-eslint(no-floating-promises)
427427
fetch(`${devServer.url}open-url`, {
428428
method: 'POST',
429429
body: JSON.stringify({ url }),

samples/expo/app/(tabs)/_layout.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ function TabBarIcon(props: {
1212
name: React.ComponentProps<typeof FontAwesome>['name'];
1313
color: string;
1414
}) {
15-
// eslint-disable-next-line react-native/no-inline-styles
1615
return <FontAwesome size={28} style={{ marginBottom: -3 }} {...props} />;
1716
}
1817

@@ -29,7 +28,6 @@ function InfoButton({ colorScheme }: { colorScheme: 'light' | 'dark' | null }) {
2928
name="info-circle"
3029
size={25}
3130
color={Colors[colorScheme ?? 'light'].text}
32-
// eslint-disable-next-line react-native/no-inline-styles
3331
style={{ marginRight: 15, opacity: pressed ? 0.5 : 1 }}
3432
/>
3533
)}

samples/react-native-macos/.oxlintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"no-shadow": "off",
99
"typescript/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "caughtErrors": "none" }],
1010
"typescript/no-require-imports": "off",
11-
"typescript/no-explicit-any": "off"
11+
"typescript/no-explicit-any": "off",
12+
"react-hooks/exhaustive-deps": "warn"
1213
},
1314
"ignorePatterns": ["node_modules/**", "macos/**"]
1415
}

samples/react-native-macos/src/App.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,6 @@ function RotatingBox() {
255255
}),
256256
-1,
257257
);
258-
// eslint-disable-next-line react-hooks/exhaustive-deps
259258
}, []);
260259

261260
const animatedStyle = useAnimatedStyle(() => ({

samples/react-native/.oxlintrc.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
"no-shadow": "off",
99
"typescript/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "caughtErrors": "none" }],
1010
"typescript/no-require-imports": "off",
11-
"typescript/no-explicit-any": "off"
11+
"typescript/no-explicit-any": "off",
12+
"react-hooks/exhaustive-deps": "warn"
1213
},
1314
"ignorePatterns": ["node_modules/**", "android/**", "ios/**"]
1415
}

0 commit comments

Comments
 (0)