Commit 10e98a6
committed
fix(ci): Include sample app and perf test changes in step-level platform gates
The step-level platform-check in sample-application, sample-application-expo,
and e2e-v2 workflows gated on needs_ios/needs_android, which only track SDK
source and native code changes. When only sample app or performance test files
changed, the job-level condition correctly triggered (via needs_sample_react_native,
needs_sample_expo), but every platform step was skipped — runners allocated,
zero meaningful work done, false green reported.
Fix by checking sample_react_native/sample_expo/perf_tests as the first
condition in each platform-check step. If the relevant files changed, all
platforms proceed without skipping.
Affected workflows:
- sample-application.yml: build and test jobs (sample_react_native)
- sample-application-expo.yml: build job (sample_expo)
- e2e-v2.yml: metrics job (perf_tests)1 parent 9972c54 commit 10e98a6
File tree
3 files changed
+30
-4
lines changed- .github/workflows
3 files changed
+30
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
69 | 77 | | |
70 | 78 | | |
71 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
81 | 89 | | |
82 | 90 | | |
83 | 91 | | |
| |||
259 | 267 | | |
260 | 268 | | |
261 | 269 | | |
262 | | - | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
263 | 276 | | |
264 | 277 | | |
265 | 278 | | |
| |||
0 commit comments