Skip to content

Commit 1e35081

Browse files
move to upper level
1 parent d208734 commit 1e35081

5 files changed

Lines changed: 50 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,32 @@
66
> make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first.
77
<!-- prettier-ignore-end -->
88
9+
## Unreleased
10+
11+
### Important Changes
12+
13+
- The `_experiments.enableLogs` and `_experiments.beforeSendLog` options were removed, use the top-level `enableLogs` and `beforeSendLog` options instead.
14+
15+
```js
16+
// before
17+
Sentry.init({
18+
_experiments: {
19+
enableLogs: true,
20+
beforeSendLog: log => {
21+
return log;
22+
},
23+
},
24+
});
25+
26+
// after
27+
Sentry.init({
28+
enableLogs: true,
29+
beforeSendLog: log => {
30+
return log;
31+
},
32+
});
33+
```
34+
935
## 7.0.0-rc.2
1036

1137
### Important Changes

packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,8 @@ protected void getSentryAndroidOptions(
283283
if (rnOptions.hasKey("enableNdk")) {
284284
options.setEnableNdk(rnOptions.getBoolean("enableNdk"));
285285
}
286-
if (rnOptions.hasKey("_experiments")) {
287-
ReadableMap experiments = rnOptions.getMap("_experiments");
288-
if (experiments.hasKey("enableLogs")) {
289-
options.getLogs().setEnabled(experiments.getBoolean("enableLogs"));
290-
}
286+
if (rnOptions.hasKey("enableLogs")) {
287+
options.getLogs().setEnabled(rnOptions.getBoolean("enableLogs"));
291288
}
292289
if (rnOptions.hasKey("spotlight")) {
293290
if (rnOptions.getType("spotlight") == ReadableType.Boolean) {

packages/core/src/js/client.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export class ReactNativeClient extends Client<ReactNativeClientOptions> {
6464
this.on('beforeSendSession', addAutoIpAddressToSession);
6565
}
6666

67-
if (options._experiments?.enableLogs) {
67+
if (options.enableLogs) {
6868
this.on('flush', () => {
6969
_INTERNAL_flushLogsBuffer(this);
7070
});

packages/core/src/js/options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ type ProfilerProps = React.ComponentProps<typeof Profiler>;
1010
type BrowserTransportOptions = Parameters<typeof makeFetchTransport>[0];
1111

1212
type BrowserExperiments = NonNullable<BrowserOptions['_experiments']>;
13-
type SharedExperimentsSubset = Pick<BrowserExperiments, 'enableLogs' | 'beforeSendLog'>;
13+
type SharedExperimentsSubset = BrowserExperiments;
1414

1515
export interface BaseReactNativeOptions {
1616
/**

samples/react-native/src/App.tsx

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,22 @@ import { isTurboModuleEnabled } from '@sentry/react-native/dist/js/utils/environ
4040
import * as ImagePicker from 'react-native-image-picker';
4141
import SpaceflightNewsScreen from './Screens/SpaceflightNewsScreen';
4242

43+
type HiddenBoolean = boolean & { readonly __hidden?: unique symbol };
44+
interface test {
45+
/** @internal dont use for now */
46+
boom: boolean
47+
}
48+
49+
let x: test = {
50+
51+
52+
53+
};
54+
55+
56+
57+
test.boom;
58+
4359
/* false by default to avoid issues in e2e tests waiting for the animation end */
4460
const RUNNING_INDICATOR = false;
4561

@@ -82,12 +98,12 @@ Sentry.init({
8298
);
8399
},
84100
_experiments: {
85-
enableLogs: true,
86-
beforeSendLog: (log) => {
87-
return log;
88-
},
89101
enableUnhandledCPPExceptionsV2: true,
90102
},
103+
enableLogs: true,
104+
beforeSendLog: (log) => {
105+
return log;
106+
},
91107
enableUserInteractionTracing: true,
92108
integrations(integrations) {
93109
integrations.push(

0 commit comments

Comments
 (0)