Commit 39391a8
refactor(e2e): Consolidate Android build scripts per review feedback
Replaces separate build-android-debug-auto.sh and build-android-debug-manual.sh
scripts with a single consolidated build-android-debug-init.sh that validates
SENTRY_DISABLE_NATIVE_START and provides clear error messages.
Key improvements:
- Single source of truth for Android build logic
- Environment variable validation with helpful error messages
- Maps true/false to auto/manual build modes
- Dynamic APK naming based on mode
- Error handling if APK not found
Package.json now calls the script directly with the env var inline,
eliminating the need for wrapper scripts while maintaining the same
developer ergonomics (yarn build-android-debug-auto/manual still work).
Addresses review feedback from lucas-zimerman at:
#5583 (comment)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 112bfc6 commit 39391a8
File tree
4 files changed
+49
-46
lines changed- samples/react-native
- scripts
4 files changed
+49
-46
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
Lines changed: 0 additions & 22 deletions
This file was deleted.
0 commit comments