other strategy to update clang/ more changes for version

Author: lucas-zimerman

.github/workflows/buildandtest.yml

@@ -52,8 +52,21 @@ jobs:
           cache-dependency-path: yarn.lock
       - name: Install Dependencies
         run: yarn install
-      - name: Setup clang-format
-        run: sudo apt install clang-21 lldb-21 lld-21
+
+      # Default of ubuntu and apt packages are too old compared to macos packages.
+      # This is required for using a newer version of clang-format.
+      - name: Install LLVM 20
+        run: |
+          sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" 20
+          sudo apt-get install -y clang-20 clang-format-20 lld-20 lldb-20
+
+      - name: Set Clang 20 as default
+        run: |
+          sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-20 200
+          sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-20 200
+          sudo update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-20 200
+          clang --version
+          clang-format --version
 
       - name: Lint
         run: yarn lint

scripts/clang-format.sh

@@ -4,29 +4,41 @@ set -eo pipefail
 
 echo "💡 If you get 'spawn Unknown system error -86', try running this script manually:"
 echo "   ./scripts/clang-format.sh $1"
-echo ""
+echo "💡 It is also recommended to use clang-version v20 or v21."
 
 # Prioritize finding clang-format executable from brew since the run-s may introduce X86/ARM64 mismatch.
 CLANG_FORMAT_PATH=""
 if [ -f "/opt/homebrew/bin/clang-format" ]; then
     CLANG_FORMAT_PATH="/opt/homebrew/bin/clang-format"
-elif [ -f "/usr/local/bin/clang-format" ]; then
-    CLANG_FORMAT_PATH="/usr/local/bin/clang-format"
 else
-    CLANG_FORMAT_PATH=$(which clang-format 2>/dev/null)
+    CLANG_FORMAT_PATH=$(which clang-format 2>/dev/null || true)
 fi
 
 if [ -z "$CLANG_FORMAT_PATH" ]; then
     echo "❌ clang-format is not installed or not found in PATH"
     echo ""
     echo "To install clang-format:"
-    echo "  • macOS: brew install clang-format"
-    echo "  • Linux: install package clang-format or clang-tools-extra"
-    echo ""
+    echo "  * macOS: brew install clang-format"
+    echo "  * Ubuntu: install package clang-format or clang-tools-extra"
+    echo "  * Arch: pacman -S clang llvm llvm-libs"
+    exit 1
+fi
+
+CLANG_VERSION="$("$CLANG_FORMAT_PATH" --version 2>/dev/null)"
+CLANG_MAJOR_VERSION="$(printf '%s' "$CLANG_VERSION" | grep -oE '[0-9]+\.[0-9]+(\.[0-9]+)?' | head -n1 | cut -d. -f1)"
+
+echo "clang-format version: $CLANG_VERSION, MAJOR: $CLANG_MAJOR_VERSION"
+
+if ! printf '%s' "$CLANG_MAJOR_VERSION" | grep -qE '^[0-9]+$'; then
+    echo "❌ Could not parse clang-format version from: $CLANG_VERSION"
     exit 1
 fi
 
-echo "clang-format version: $($CLANG_FORMAT_PATH --version)"
+REQUIRED_MAJOR=20
+if [ "$CLANG_MAJOR_VERSION" -lt "$REQUIRED_MAJOR" ]; then
+    echo "❌ clang-format major version $CLANG_MAJOR_VERSION is lower than required $REQUIRED_MAJOR"
+    exit 1
+fi
 
 # Check if an argument is provided
 if [ $# -eq 0 ]; then