revert: Remove redundant OTHER_CFLAGS from pod_target_xcconfig

antonis · claude · antonis · commit 4280fa9d02a8 · 2026-04-01T11:25:25.000+02:00
The compiler flags (SENTRY_PROFILING_SUPPORTED, NEW_HERMES_RUNTIME, etc.)
are already applied per-file via s.compiler_flags, which
install_modules_dependencies preserves. Adding them to pod_target_xcconfig
was redundant.

The actual fix for the iOS build was the REACT_NATIVE_NODE_MODULES_DIR
env var in the Podfile, which ensures the podspec detects the app's
RN version instead of the SDK's devDependency version in the monorepo.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/core/RNSentry.podspec b/packages/core/RNSentry.podspec
@@ -48,8 +48,7 @@ Pod::Spec.new do |s|
 
   s.pod_target_xcconfig = {
     'DEFINES_MODULE' => 'YES',
-    'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"',
-    'OTHER_CFLAGS' => other_cflags
+    'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"'
   }
 
   s.dependency 'Sentry', '9.8.0'

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,7 @@ Pod::Spec.new do \|s\|`
`48`	`48`
`49`	`49`	`s.pod_target_xcconfig = {`
`50`	`50`	`'DEFINES_MODULE' => 'YES',`
`51`		`- 'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"',`
`52`		`- 'OTHER_CFLAGS' => other_cflags`
	`51`	`+ 'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"'`
`53`	`52`	`}`
`54`	`53`
`55`	`54`	`s.dependency 'Sentry', '9.8.0'`