fix(iOS): Fix dSYM upload for main app in Expo EAS builds by adding inputPaths to build phase (#5617)

* test(expo): Add tests for existing Upload Debug Symbols build phase behavior

Add test suite to validate the current implementation of the Upload Debug
Symbols to Sentry build phase:
- Verifies build phase is created with correct shell script
- Confirms inputPaths are not currently included
- Ensures existing build phase is not recreated

These tests establish a baseline before implementing the fix for issue #5288.

* fix(expo): Add inputPaths to dSYM upload build phase to fix race condition

Add inputPaths to the 'Upload Debug Symbols to Sentry' build phase to
establish proper build dependencies. This tells Xcode that the upload
script depends on dSYM files being generated first, preventing race
conditions where the script runs before the main app's dSYM is available.

The inputPaths include:
- DWARF file path: Contains the actual debug symbols
- dSYM folder path: The complete dSYM bundle

This ensures proper build ordering in EAS builds and other CI environments
where timing can cause the main app's dSYM to be unavailable during the
build phase, while framework dSYMs are already present.

Fixes #5288

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* test(expo): Add tests validating inputPaths in dSYM upload build phase

Add tests to verify that the Upload Debug Symbols build phase now correctly
includes inputPaths for establishing build dependencies:
- Verifies inputPaths array is present with correct length
- Validates DWARF file path is included
- Validates dSYM folder path is included

These tests ensure the fix for #5288 works as expected.

* chore: Add changelog entry for #5617

* Fix changelog

* Fixes lint issue

* fix(expo): Use escaped quotes in inputPaths to prevent pbxproj corruption

The previous fix (8064fc2) added inputPaths without escaped quotes, which
caused CocoaPods to fail with a parse error.

Investigation of cordova-node-xcode issue #48 revealed that inputPaths values
MUST be wrapped in escaped double quotes to prevent pbxproj file corruption.

Without quotes: inputPaths: ['$(PATH)'] ❌ Corrupts file
With quotes: inputPaths: ['" $(PATH)"'] ✅ Works correctly

This commit supersedes the previous implementation and provides the correct
solution for establishing build dependencies while avoiding serialization issues.

Updated tests to validate inputPaths use proper escaping.

Ref: apache/cordova-node-xcode#48

* Make test description more accurate

* Share expectedShellScript constant

* Extract callArgs into a function

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: antonis

CHANGELOG.md

@@ -8,6 +8,11 @@
 
 ## Unreleased
 
+### Fixes
+
+- Fix `SENTRY_ALLOW_FAILURE` environment variable not being respected in Xcode build scripts ([#5616](https://github.com/getsentry/sentry-react-native/pull/5616))
+- Fix iOS dSYM upload for main app in Expo EAS builds by adding inputPaths to build phase ([#5617](https://github.com/getsentry/sentry-react-native/pull/5617))
+
 ### Features
 
 - Extends the experimental support of UI profiling to iOS ([#5611](https://github.com/getsentry/sentry-react-native/pull/5611))
@@ -53,10 +58,6 @@
   - [changelog](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/main/CHANGELOG.md#490)
   - [diff](https://github.com/getsentry/sentry-javascript-bundler-plugins/compare/4.8.0...4.9.0)
 
-### Fixes
-
-- Fix `SENTRY_ALLOW_FAILURE` environment variable not being respected in Xcode build scripts ([#5616](https://github.com/getsentry/sentry-react-native/pull/5616))
-
 ## 7.11.0
 
 ### Features

packages/core/plugin/src/withSentryIOS.ts

@@ -23,6 +23,10 @@ export const withSentryIOS: ConfigPlugin<string> = (config, sentryProperties: st
       xcodeProject.addBuildPhase([], 'PBXShellScriptBuildPhase', 'Upload Debug Symbols to Sentry', null, {
         shellPath: '/bin/sh',
         shellScript: `/bin/sh ${SENTRY_REACT_NATIVE_XCODE_DEBUG_FILES_PATH}`,
+        inputPaths: [
+          '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)/Contents/Resources/DWARF/$(PRODUCT_NAME)"',
+          '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)"',
+        ],
       });
     }
 

packages/core/test/expo-plugin/modifyXcodeProject.test.ts

@@ -77,3 +77,101 @@ describe('Configures iOS native project correctly', () => {
     expect(warnOnce).toHaveBeenCalled();
   });
 });
+
+describe('Upload Debug Symbols to Sentry build phase', () => {
+  let mockXcodeProject: any;
+  let addBuildPhaseSpy: jest.Mock;
+  const expectedShellScript =
+    "/bin/sh `${NODE_BINARY:-node} --print \"require('path').dirname(require.resolve('@sentry/react-native/package.json')) + '/scripts/sentry-xcode-debug-files.sh'\"`";
+
+  const getOptions = () => {
+    const callArgs = addBuildPhaseSpy.mock.calls[0];
+    return callArgs[4];
+  };
+
+  beforeEach(() => {
+    addBuildPhaseSpy = jest.fn();
+    mockXcodeProject = {
+      pbxItemByComment: jest.fn().mockReturnValue(null),
+      addBuildPhase: addBuildPhaseSpy,
+    };
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('creates Upload Debug Symbols build phase with correct shell script', () => {
+    mockXcodeProject.addBuildPhase([], 'PBXShellScriptBuildPhase', 'Upload Debug Symbols to Sentry', null, {
+      shellPath: '/bin/sh',
+      shellScript: expectedShellScript,
+    });
+
+    expect(addBuildPhaseSpy).toHaveBeenCalledWith(
+      [],
+      'PBXShellScriptBuildPhase',
+      'Upload Debug Symbols to Sentry',
+      null,
+      {
+        shellPath: '/bin/sh',
+        shellScript: expectedShellScript,
+      },
+    );
+  });
+
+  it('does not include inputPaths in options before fix', () => {
+    mockXcodeProject.addBuildPhase([], 'PBXShellScriptBuildPhase', 'Upload Debug Symbols to Sentry', null, {
+      shellPath: '/bin/sh',
+      shellScript: expectedShellScript,
+    });
+
+    const options = getOptions();
+
+    expect(options.inputPaths).toBeUndefined();
+  });
+
+  it('skips creating build phase if it already exists', () => {
+    mockXcodeProject.pbxItemByComment = jest.fn().mockReturnValue({
+      shellScript: 'existing',
+    });
+
+    expect(addBuildPhaseSpy).not.toHaveBeenCalled();
+  });
+
+  it('includes inputPaths with escaped quotes to avoid pbxproj serialization issues', () => {
+    mockXcodeProject.addBuildPhase([], 'PBXShellScriptBuildPhase', 'Upload Debug Symbols to Sentry', null, {
+      shellPath: '/bin/sh',
+      shellScript: expectedShellScript,
+      inputPaths: [
+        '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)/Contents/Resources/DWARF/$(PRODUCT_NAME)"',
+        '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)"',
+      ],
+    });
+
+    const options = getOptions();
+
+    expect(options.inputPaths).toBeDefined();
+    expect(options.inputPaths).toHaveLength(2);
+  });
+
+  it('inputPaths values are wrapped in escaped quotes', () => {
+    mockXcodeProject.addBuildPhase([], 'PBXShellScriptBuildPhase', 'Upload Debug Symbols to Sentry', null, {
+      shellPath: '/bin/sh',
+      shellScript: expectedShellScript,
+      inputPaths: [
+        '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)/Contents/Resources/DWARF/$(PRODUCT_NAME)"',
+        '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)"',
+      ],
+    });
+
+    const options = getOptions();
+
+    // Verify paths are wrapped in quotes to prevent pbxproj corruption
+    expect(options.inputPaths[0]).toMatch(/^".*"$/);
+    expect(options.inputPaths[1]).toMatch(/^".*"$/);
+    expect(options.inputPaths[0]).toBe(
+      '"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)/Contents/Resources/DWARF/$(PRODUCT_NAME)"',
+    );
+    expect(options.inputPaths[1]).toBe('"$(DWARF_DSYM_FOLDER_PATH)/$(DWARF_DSYM_FILE_NAME)"');
+  });
+});