Skip to content

Commit 4eadfc2

Browse files
Fix(CI): Ignore folder path fix for typescript 3.8 test (#5720)
* test pure * relink rn after yarn install Co-authored-by: Claude <noreply@anthropic.com> * fix yalc install Co-authored-by: Claude <noreply@anthropic.com> * test disable security patches * keep original resolutions * debug output bundle * extra debug data * extra fields for npmignore/ remove debug logs. Co-authored-by: Claude <noreply@anthropic.com> * Apply suggestions from code review * Update .github/workflows/buildandtest.yml * Update dev-packages/type-check/run-type-check.sh * rollback changes & remove uneeded gitignore * add back dist/ ts to ignore list --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent d4ebf2b commit 4eadfc2

File tree

6 files changed

+25
-11
lines changed

6 files changed

+25
-11
lines changed

.github/workflows/buildandtest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ jobs:
175175
name: ts3.8
176176
path: packages/core/ts3.8
177177
- name: Install Global Dependencies
178-
run: npm i -g add yalc
178+
run: npm i -g yalc
179179
- name: Type Check
180180
working-directory: dev-packages/type-check
181181
run: yarn type-check

dev-packages/type-check/run-type-check.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,14 @@ yalc publish
1010

1111
cd "${__dirpath}/ts3.8-test"
1212

13+
# Add yalc package (creates .yalc/ directory and updates package.json)
1314
yalc add @sentry/react-native
1415

1516
yarn install
1617

18+
# Re-add yalc package to ensure it's in node_modules (yarn might have removed it)
19+
yalc add @sentry/react-native
20+
1721
echo "Removing duplicate React types..."
1822
rm -rf ./node_modules/@types/react-native/node_modules/@types/react
1923

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@
5050
"performance-tests/TestAppPlain",
5151
"performance-tests/TestAppSentry"
5252
],
53-
"//": [
54-
"Appium has a dependency on @xmldom/xmldom@^0.x, which causes chromedrive build to fail yarn install",
55-
"See: https://github.com/appium/appium-chromedriver/pull/424"
56-
],
5753
"volta": {
5854
"node": "18.20.8",
5955
"yarn": "3.6.4"
6056
},
57+
"//": [
58+
"Appium has a dependency on @xmldom/xmldom@^0.x, which causes chromedrive build to fail yarn install",
59+
"See: https://github.com/appium/appium-chromedriver/pull/424"
60+
],
6161
"resolutions": {
6262
"appium-chromedriver@npm:5.6.73/@xmldom/xmldom": "0.8.10",
6363
"fast-xml-parser": "^5.3.6",

packages/core/.npmignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
!LICENSE.md
55
!CHANGELOG.md
66
!README.md
7+
!/dist/
8+
!/ts3.8/
79
!/dist/**/*
810
!ts3.8/**/*
911
!RNSentry.podspec
-2 Bytes
Binary file not shown.

yarn.lock

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20114,14 +20114,22 @@ __metadata:
2011420114
languageName: node
2011520115
linkType: hard
2011620116

20117+
"fast-xml-builder@npm:^1.0.0":
20118+
version: 1.0.0
20119+
resolution: "fast-xml-builder@npm:1.0.0"
20120+
checksum: d6fb6d860ebb67c0dbec4c91a5cde3bf3e4cc40407db249539fe0d4e98e5c1bc09b3d45e5cbc412aaee8dd16605467f8c054c104fbccba23cf78ec15ff8767ab
20121+
languageName: node
20122+
linkType: hard
20123+
2011720124
"fast-xml-parser@npm:^5.3.6":
20118-
version: 5.3.7
20119-
resolution: "fast-xml-parser@npm:5.3.7"
20125+
version: 5.4.1
20126+
resolution: "fast-xml-parser@npm:5.4.1"
2012020127
dependencies:
20128+
fast-xml-builder: ^1.0.0
2012120129
strnum: ^2.1.2
2012220130
bin:
2012320131
fxparser: src/cli/cli.js
20124-
checksum: 0bb307bc63a01c079ae28b6b62eeea0007d787e6ab47dfca493f40305f78aeedea2906b2632bf0eb9d4d868e748c77c70393a808441fb5949c9d2e6f8f2825f0
20132+
checksum: 98b8d2f208dea6be10740509e4ef59dc175584cfb29cb3f82849f0a79645ccaf40916589533029c30b4b47a78e744e8fc08ff468f214a231f450e51f0d8d32c6
2012520133
languageName: node
2012620134
linkType: hard
2012720135

@@ -32792,15 +32800,15 @@ __metadata:
3279232800
linkType: hard
3279332801

3279432802
"tar@npm:^7.5.7":
32795-
version: 7.5.7
32796-
resolution: "tar@npm:7.5.7"
32803+
version: 7.5.9
32804+
resolution: "tar@npm:7.5.9"
3279732805
dependencies:
3279832806
"@isaacs/fs-minipass": ^4.0.0
3279932807
chownr: ^3.0.0
3280032808
minipass: ^7.1.2
3280132809
minizlib: ^3.1.0
3280232810
yallist: ^5.0.0
32803-
checksum: 82fa04804b6cae4c0b46b84e97a08c39e1c17bb959350baa32d139bcf5e1fc7ebc3ceb72465dd3e2e311992386ecc13599a257d5672158490ceb9464146d5573
32811+
checksum: 26fbbdf536895814167d03e4883f80febb6520729169c54d0f29ee8a163557283862752493f0e5b60800a6f3608aac3250c41fac8e20a4f056ba4fa63f3dbad7
3280432812
languageName: node
3280532813
linkType: hard
3280632814

0 commit comments

Comments
 (0)