Skip to content

Commit 67eb423

Browse files
antonisclaude
andauthored
fix(core): Restore broken release process after @sentry/react-native 8.9.0 (#6037)
* fix(core): Restore broken release process after @sentry/react-native 8.9.0 8.9.0 shipped to npm with an unresolved workspace:* spec for @sentry/expo-upload-sourcemaps in its published tarball, preventing installation. Three underlying issues: 1. packages/core/scripts/build-tarball.sh used npm pack, which does not rewrite yarn's workspace: protocol. Switch to yarn pack, which substitutes workspace:* with the concrete version. Same change applied to packages/expo-upload-sourcemaps/scripts/build-tarball.sh for consistency. 2. .github/workflows/buildandtest.yml archived only packages/core/*.tgz, so the new package's tarball never reached craft. Extend the archive path. 3. .craft.yml's registry target entry for the new @sentry/expo-upload-sourcemaps package missed the required name field, which craft requires for packages not yet present in sentry-release-registry. 8.9.0 has been deprecated on npm. 8.9.1 will be the first working version of the new package setup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Update changelog * Update changelog --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7d6fd3a commit 67eb423

5 files changed

Lines changed: 26 additions & 5 deletions

File tree

.craft.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ targets:
99
npm:@sentry/react-native:
1010
includeNames: /^sentry-react-native-\d.*\.tgz$/
1111
npm:@sentry/expo-upload-sourcemaps:
12+
name: '@sentry/expo-upload-sourcemaps'
1213
includeNames: /^sentry-expo-upload-sourcemaps-\d.*\.tgz$/

.github/workflows/buildandtest.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ jobs:
166166
name: ${{ github.sha }}
167167
path: |
168168
${{ github.workspace }}/packages/core/*.tgz
169+
${{ github.workspace }}/packages/expo-upload-sourcemaps/*.tgz
169170
170171
job_type_check:
171172
name: Type Check Typescript 3.8

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
### Fixes
2222

23+
- Fix `@sentry/expo-upload-sourcemaps` publishing issue ([#6037](https://github.com/getsentry/sentry-react-native/pull/6037))
2324
- Fix iOS UI profiling options being silently ignored ([#6012](https://github.com/getsentry/sentry-react-native/pull/6012))
2425
- Fix `_experiments.enableUnhandledCPPExceptionsV2` being silently ignored on iOS ([#6014](https://github.com/getsentry/sentry-react-native/pull/6014))
2526
- Check `captureReplay` return value in iOS bridge to avoid linking error events to uncaptured replays ([#6008](https://github.com/getsentry/sentry-react-native/pull/6008))
Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,17 @@
11
#!/bin/bash
2+
set -e
23

3-
rm -f $(dirname "$0")/../*.tgz
4+
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
5+
PKG_DIR="$SCRIPT_DIR/.."
46

5-
cp $(dirname "$0")/../../../README.md $(dirname "$0")/../README.md
7+
cd "$PKG_DIR"
68

7-
npm pack
9+
rm -f sentry-react-native-*.tgz
10+
11+
cp ../../README.md README.md
12+
13+
# Use `yarn pack` instead of `npm pack` so `workspace:*` dependency specs are
14+
# rewritten to concrete versions in the published tarball. npm pack leaves
15+
# the spec as `workspace:*`, which consumers cannot resolve.
16+
VERSION=$(node -p "require('./package.json').version")
17+
yarn pack --out "sentry-react-native-${VERSION}.tgz"
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
#!/bin/bash
2+
set -e
23

3-
rm -f $(dirname "$0")/../sentry-expo-upload-sourcemaps-*.tgz
4+
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
5+
PKG_DIR="$SCRIPT_DIR/.."
46

5-
npm pack
7+
cd "$PKG_DIR"
8+
9+
rm -f sentry-expo-upload-sourcemaps-*.tgz
10+
11+
# Use `yarn pack` instead of `npm pack` for consistency with packages/core.
12+
VERSION=$(node -p "require('./package.json').version")
13+
yarn pack --out "sentry-expo-upload-sourcemaps-${VERSION}.tgz"

0 commit comments

Comments
 (0)