ignored rule import/first for tests, rolled back tests affected by mock order

lucas-zimerman · lucas-zimerman · commit 84d73346e660 · 2025-05-26T23:56:06.000-03:00
diff --git a/packages/core/.eslintrc.js b/packages/core/.eslintrc.js
@@ -38,6 +38,7 @@ module.exports = {
         '@typescript-eslint/no-empty-function': 'off',
         '@typescript-eslint/no-explicit-any': 'off',
         '@typescript-eslint/unbound-method': 'off',
+        'import/first': 'off',
       },
     },
     {
diff --git a/packages/core/test/integrations/integrationsexecutionorder.test.ts b/packages/core/test/integrations/integrationsexecutionorder.test.ts
@@ -1,14 +1,15 @@
+import * as mockWrapper from '../mockWrapper';
+
+jest.mock('../../src/js/wrapper', () => mockWrapper);
+jest.mock('../../src/js/utils/environment');
+
 import { defaultStackParser } from '@sentry/browser';
 import type { Integration } from '@sentry/core';
 import { ReactNativeClient } from '../../src/js/client';
 import { getDefaultIntegrations } from '../../src/js/integrations/default';
 import type { ReactNativeClientOptions } from '../../src/js/options';
 import { isHermesEnabled, notWeb } from '../../src/js/utils/environment';
 import { MOCK_DSN } from '../mockDsn';
-import * as mockWrapper from '../mockWrapper';
-
-jest.mock('../../src/js/wrapper', () => mockWrapper);
-jest.mock('../../src/js/utils/environment');
 
 describe('Integration execution order', () => {
   describe('mobile hermes', () => {
diff --git a/packages/core/test/profiling/integration.test.ts b/packages/core/test/profiling/integration.test.ts
@@ -1,3 +1,9 @@
+import * as mockWrapper from '../mockWrapper';
+
+jest.mock('../../src/js/wrapper', () => mockWrapper);
+jest.mock('../../src/js/utils/environment');
+jest.mock('../../src/js/profiling/debugid');
+
 import type { Envelope, Event, Integration, Profile, Span, ThreadCpuProfile, Transport } from '@sentry/core';
 import { getClient, spanToJSON } from '@sentry/core';
 import * as Sentry from '../../src/js';
@@ -7,7 +13,6 @@ import { hermesProfilingIntegration } from '../../src/js/profiling/integration';
 import type { AndroidProfileEvent } from '../../src/js/profiling/types';
 import { getDefaultEnvironment, isHermesEnabled, notWeb } from '../../src/js/utils/environment';
 import { MOCK_DSN } from '../mockDsn';
-import * as mockWrapper from '../mockWrapper';
 import { envelopeItemPayload, envelopeItems } from '../testutils';
 import {
   createMockMinimalValidAndroidProfile,
@@ -16,10 +21,6 @@ import {
   createMockMinimalValidHermesProfile,
 } from './fixtures';
 
-jest.mock('../../src/js/wrapper', () => mockWrapper);
-jest.mock('../../src/js/utils/environment');
-jest.mock('../../src/js/profiling/debugid');
-
 const SEC_TO_MS = 1e6;
 
 describe('profiling integration', () => {
diff --git a/packages/core/test/scopeSync.test.ts b/packages/core/test/scopeSync.test.ts
@@ -3,10 +3,11 @@ import * as SentryCore from '@sentry/core';
 import { Scope } from '@sentry/core';
 import { enableSyncToNative } from '../src/js/scopeSync';
 import { getDefaultTestClientOptions, TestClient } from './mocks/client';
-import { NATIVE } from './mockWrapper';
 
 jest.mock('../src/js/wrapper', () => jest.requireActual('./mockWrapper'));
 
+import { NATIVE } from './mockWrapper';
+
 jest.mock('../src/js/wrapper');
 
 describe('ScopeSync', () => {
diff --git a/packages/core/test/tools/collectModules.test.ts b/packages/core/test/tools/collectModules.test.ts
@@ -1,11 +1,12 @@
 import { logger } from '@sentry/core';
 import { existsSync, readFileSync, rmdirSync, unlinkSync } from 'fs';
 import { dirname } from 'path';
-import ModulesCollector from '../../src/js/tools/ModulesCollector';
 
 jest.mock('@sentry/core');
 (logger.enable as jest.Mock).mockImplementation(() => {});
 
+import ModulesCollector from '../../src/js/tools/ModulesCollector';
+
 describe('collectModules', () => {
   test('should collect modules from multiple modules paths', () => {
     const modules = ModulesCollector.collect(
diff --git a/packages/core/test/tools/sentryBabelTransformer.test.ts b/packages/core/test/tools/sentryBabelTransformer.test.ts
@@ -4,10 +4,11 @@ import {
   SENTRY_BABEL_TRANSFORMER_OPTIONS,
   SENTRY_DEFAULT_BABEL_TRANSFORMER_PATH,
 } from '../../src/js/tools/sentryBabelTransformerUtils';
-import type { BabelTransformerArgs } from '../../src/js/tools/vendor/metro/metroBabelTransformer';
 
 process.env[SENTRY_DEFAULT_BABEL_TRANSFORMER_PATH] = require.resolve('./fixtures/mockBabelTransformer.js');
 
+import type { BabelTransformerArgs } from '../../src/js/tools/vendor/metro/metroBabelTransformer';
+
 const MockDefaultBabelTransformer: {
   transform: jest.Mock;
   getCacheKey: jest.Mock;
diff --git a/packages/core/test/tracing/reactnativetracing.test.ts b/packages/core/test/tracing/reactnativetracing.test.ts
@@ -1,9 +1,5 @@
 import * as SentryBrowser from '@sentry/browser';
 import type { Event } from '@sentry/core';
-import { reactNativeTracingIntegration } from '../../src/js/tracing/reactnativetracing';
-import { isWeb } from '../../src/js/utils/environment';
-import type { TestClient } from '../mocks/client';
-import { setupTestClient } from '../mocks/client';
 
 jest.mock('../../src/js/wrapper', () => {
   return {
@@ -17,6 +13,11 @@ jest.mock('../../src/js/wrapper', () => {
   };
 });
 
+import { reactNativeTracingIntegration } from '../../src/js/tracing/reactnativetracing';
+import { isWeb } from '../../src/js/utils/environment';
+import type { TestClient } from '../mocks/client';
+import { setupTestClient } from '../mocks/client';
+
 jest.mock('../../src/js/tracing/utils', () => {
   const originalUtils = jest.requireActual('../../src/js/tracing/utils');
 
diff --git a/packages/core/test/tracing/reactnavigation.stalltracking.test.ts b/packages/core/test/tracing/reactnavigation.stalltracking.test.ts
@@ -1,3 +1,8 @@
+jest.mock('../../src/js/tracing/utils', () => ({
+  ...jest.requireActual('../../src/js/tracing/utils'),
+  isNearToNow: jest.fn(),
+}));
+
 import { getCurrentScope, getGlobalScope, getIsolationScope, setCurrentClient, startSpanManual } from '@sentry/core';
 import { reactNativeTracingIntegration, reactNavigationIntegration } from '../../src/js';
 import { stallTrackingIntegration } from '../../src/js/tracing/integrations/stalltracking';
@@ -7,11 +12,6 @@ import { getDefaultTestClientOptions, TestClient } from '../mocks/client';
 import { expectStallMeasurements } from './integrations/stallTracking/stalltrackingutils';
 import { createMockNavigationAndAttachTo } from './reactnavigationutils';
 
-jest.mock('../../src/js/tracing/utils', () => ({
-  ...jest.requireActual('../../src/js/tracing/utils'),
-  isNearToNow: jest.fn(),
-}));
-
 jest.useFakeTimers({ advanceTimers: 1 });
 
 describe('StallTracking with ReactNavigation', () => {
diff --git a/packages/core/test/tracing/reactnavigation.ttid.test.tsx b/packages/core/test/tracing/reactnavigation.ttid.test.tsx
@@ -2,6 +2,15 @@ import type { Scope, Span, SpanJSON, TransactionEvent, Transport } from '@sentry
 import { getActiveSpan, spanToJSON, timestampInSeconds } from '@sentry/core';
 import * as TestRenderer from '@testing-library/react-native'
 import * as React from 'react';
+import * as mockWrapper from '../mockWrapper';
+import * as mockedSentryEventEmitter from '../utils/mockedSentryeventemitterfallback';
+import * as mockedtimetodisplaynative from './mockedtimetodisplaynative';
+
+jest.mock('../../src/js/wrapper', () => mockWrapper);
+jest.mock('../../src/js/utils/environment');
+jest.mock('../../src/js/utils/sentryeventemitterfallback', () => mockedSentryEventEmitter);
+jest.mock('../../src/js/tracing/timetodisplaynative', () => mockedtimetodisplaynative);
+
 import * as Sentry from '../../src/js';
 import { startSpanManual } from '../../src/js';
 import { TimeToFullDisplay, TimeToInitialDisplay } from '../../src/js/tracing';
@@ -11,17 +20,10 @@ import { SPAN_THREAD_NAME, SPAN_THREAD_NAME_JAVASCRIPT } from '../../src/js/trac
 import { isHermesEnabled, notWeb } from '../../src/js/utils/environment';
 import { RN_GLOBAL_OBJ } from '../../src/js/utils/worldwide';
 import { MOCK_DSN } from '../mockDsn';
-import * as mockWrapper from '../mockWrapper';
 import { nowInSeconds, secondInFutureTimestampMs } from '../testutils';
-import * as mockedSentryEventEmitter from '../utils/mockedSentryeventemitterfallback';
-import * as mockedtimetodisplaynative from './mockedtimetodisplaynative';
 import { mockRecordedTimeToDisplay } from './mockedtimetodisplaynative';
 import { createMockNavigationAndAttachTo } from './reactnavigationutils';
 
-jest.mock('../../src/js/wrapper', () => mockWrapper);
-jest.mock('../../src/js/utils/environment');
-jest.mock('../../src/js/utils/sentryeventemitterfallback', () => mockedSentryEventEmitter);
-jest.mock('../../src/js/tracing/timetodisplaynative', () => mockedtimetodisplaynative);
 
 const SCOPE_SPAN_FIELD = '_sentrySpan';
 
diff --git a/packages/core/test/tracing/timetodisplay.test.tsx b/packages/core/test/tracing/timetodisplay.test.tsx
@@ -1,5 +1,16 @@
 import type { Event, Measurements, Span, SpanJSON} from '@sentry/core';
 import { getCurrentScope, getGlobalScope, getIsolationScope, logger , setCurrentClient, spanToJSON, startSpanManual } from '@sentry/core';
+
+jest.spyOn(logger, 'warn');
+
+import * as mockWrapper from '../mockWrapper';
+
+jest.mock('../../src/js/wrapper', () => mockWrapper);
+
+import * as mockedtimetodisplaynative from './mockedtimetodisplaynative';
+
+jest.mock('../../src/js/tracing/timetodisplaynative', () => mockedtimetodisplaynative);
+
 import * as React from 'react';
 import * as TestRenderer from 'react-test-renderer';
 import { timeToDisplayIntegration } from '../../src/js/tracing/integrations/timeToDisplayIntegration';
@@ -9,13 +20,8 @@ import { SPAN_THREAD_NAME , SPAN_THREAD_NAME_JAVASCRIPT } from '../../src/js/tra
 import { startTimeToFullDisplaySpan, startTimeToInitialDisplaySpan, TimeToFullDisplay, TimeToInitialDisplay } from '../../src/js/tracing/timetodisplay';
 import { isTurboModuleEnabled } from '../../src/js/utils/environment';
 import { getDefaultTestClientOptions, TestClient } from '../mocks/client';
-import * as mockWrapper from '../mockWrapper';
 import { nowInSeconds, secondAgoTimestampMs, secondInFutureTimestampMs } from '../testutils';
-import * as mockedtimetodisplaynative from './mockedtimetodisplaynative';
 
-jest.spyOn(logger, 'warn');
-jest.mock('../../src/js/wrapper', () => mockWrapper);
-jest.mock('../../src/js/tracing/timetodisplaynative', () => mockedtimetodisplaynative);
 jest.mock('../../src/js/utils/environment', () => ({
   isWeb: jest.fn().mockReturnValue(false),
   isTurboModuleEnabled: jest.fn().mockReturnValue(false),
diff --git a/packages/core/test/tracing/timetodisplaynative.web.test.tsx b/packages/core/test/tracing/timetodisplaynative.web.test.tsx
@@ -1,6 +1,3 @@
-import { getRNSentryOnDrawReporter } from '../../src/js/tracing/timetodisplaynative';
-import { ReactNativeLibraries } from '../../src/js/utils/rnlibraries';
-
 jest.mock('react-native', () => {
   const RN = jest.requireActual('react-native');
   // Fixes TypeError: Cannot set property UIManager of #<Object> which has only a getter
@@ -10,6 +7,9 @@ jest.mock('react-native', () => {
   return RN;
 });
 
+import { getRNSentryOnDrawReporter } from '../../src/js/tracing/timetodisplaynative';
+import { ReactNativeLibraries } from '../../src/js/utils/rnlibraries';
+
 jest.mock('../../src/js/utils/rnlibraries', () => {
   const webLibrary = jest.requireActual('../../src/js/utils/rnlibraries.web');
   return {
diff --git a/packages/core/test/utils/sentryeventemitterfallback.test.ts b/packages/core/test/utils/sentryeventemitterfallback.test.ts
@@ -1,7 +1,6 @@
 import { logger } from '@sentry/core';
 import { NewFrameEventName } from '../../src/js/utils/sentryeventemitter';
 import { createSentryFallbackEventEmitter } from '../../src/js/utils/sentryeventemitterfallback';
-import { NATIVE } from '../../src/js/wrapper';
 
 // Mock dependencies
 jest.mock('../../src/js/utils/environment', () => ({
@@ -10,6 +9,8 @@ jest.mock('../../src/js/utils/environment', () => ({
 
 jest.mock('../../src/js/wrapper', () => jest.requireActual('../mockWrapper'));
 
+import { NATIVE } from '../../src/js/wrapper';
+
 jest.spyOn(logger, 'warn');
 jest.spyOn(logger, 'log');
 jest.spyOn(logger, 'error');
diff --git a/packages/core/test/wrap.mocked.test.tsx b/packages/core/test/wrap.mocked.test.tsx
@@ -2,8 +2,6 @@
 import { render } from '@testing-library/react-native';
 import * as React from 'react';
 import type { ReactNativeWrapperOptions } from 'src/js/options';
-import { wrap } from '../src/js/sdk';
-import { ReactNativeProfiler } from '../src/js/tracing';
 
 jest.doMock('../src/js/touchevents', () => {
   return {
@@ -32,6 +30,9 @@ jest.doMock('../src/js/feedback/FeedbackWidgetManager', () => {
     };
 });
 
+import { wrap } from '../src/js/sdk';
+import { ReactNativeProfiler } from '../src/js/tracing';
+
 describe('Sentry.wrap', () => {
 
     const DummyComponent: React.FC<{ value?: string }> = ({ value }) => <div>{value}</div>;

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ module.exports = {`
`38`	`38`	`'@typescript-eslint/no-empty-function': 'off',`
`39`	`39`	`'@typescript-eslint/no-explicit-any': 'off',`
`40`	`40`	`'@typescript-eslint/unbound-method': 'off',`
	`41`	`+ 'import/first': 'off',`
`41`	`42`	`},`
`42`	`43`	`},`
`43`	`44`	`{`