style(android): Satisfy PMD SimplifyBooleanReturns

antonis · claude · antonis · commit 8604b04338b5 · 2026-04-28T11:14:09.000+02:00
Collapse the trailing if/return-false in isAllowedUri into a single
boolean expression.

Co-Authored-By: Claude Opus 4.7 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java b/packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
@@ -1142,10 +1142,7 @@ static boolean isAllowedUri(@NotNull Uri uri, @Nullable Context ctx) {
     if ("content".equals(lowerScheme)) {
       return isAllowedContentAuthority(uri.getAuthority(), ctx);
     }
-    if ("file".equals(lowerScheme)) {
-      return isPathUnderAppDirs(uri.getPath(), ctx);
-    }
-    return false;
+    return "file".equals(lowerScheme) && isPathUnderAppDirs(uri.getPath(), ctx);
   }
 
   @VisibleForTesting

Original file line number	Diff line number	Diff line change
`@@ -1142,10 +1142,7 @@ static boolean isAllowedUri(@NotNull Uri uri, @Nullable Context ctx) {`
`1142`	`1142`	`if ("content".equals(lowerScheme)) {`
`1143`	`1143`	`return isAllowedContentAuthority(uri.getAuthority(), ctx);`
`1144`	`1144`	`}`
`1145`		`- if ("file".equals(lowerScheme)) {`
`1146`		`- return isPathUnderAppDirs(uri.getPath(), ctx);`
`1147`		`- }`
`1148`		`- return false;`
	`1145`	`+ return "file".equals(lowerScheme) && isPathUnderAppDirs(uri.getPath(), ctx);`
`1149`	`1146`	`}`
`1150`	`1147`
`1151`	`1148`	`@VisibleForTesting`