Skip to content

Commit 892cb53

Browse files
noahsmartinnoahsmartin
committed
ref: Use SentryOptionsInternal
1 parent 7e38386 commit 892cb53

2 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ final class RNSentryReplayOptions: XCTestCase {
6767
] as NSDictionary).mutableCopy() as! NSMutableDictionary
6868
RNSentryReplay.updateOptions(optionsDict)
6969

70-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
70+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
7171
XCTAssertEqual(actualOptions.sessionReplay.sessionSampleRate, 0.75)
7272
}
7373

@@ -78,7 +78,7 @@ final class RNSentryReplayOptions: XCTestCase {
7878
] as NSDictionary).mutableCopy() as! NSMutableDictionary
7979
RNSentryReplay.updateOptions(optionsDict)
8080

81-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
81+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
8282
XCTAssertEqual(actualOptions.sessionReplay.onErrorSampleRate, 0.75)
8383
}
8484

@@ -108,7 +108,7 @@ final class RNSentryReplayOptions: XCTestCase {
108108

109109
RNSentryReplay.updateOptions(optionsDict)
110110

111-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
111+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
112112

113113
XCTAssertEqual(actualOptions.sessionReplay.maskAllImages, true)
114114
assertContainsClass(classArray: actualOptions.sessionReplay.maskedViewClasses, stringClass: "RCTImageView")
@@ -123,7 +123,7 @@ final class RNSentryReplayOptions: XCTestCase {
123123

124124
RNSentryReplay.updateOptions(optionsDict)
125125

126-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
126+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
127127

128128
XCTAssertEqual(actualOptions.sessionReplay.maskAllImages, false)
129129
XCTAssertEqual(actualOptions.sessionReplay.maskedViewClasses.count, 0)
@@ -138,7 +138,7 @@ final class RNSentryReplayOptions: XCTestCase {
138138

139139
RNSentryReplay.updateOptions(optionsDict)
140140

141-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
141+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
142142

143143
XCTAssertEqual(actualOptions.sessionReplay.maskAllText, true)
144144
assertContainsClass(classArray: actualOptions.sessionReplay.maskedViewClasses, stringClass: "RCTTextView")
@@ -162,7 +162,7 @@ final class RNSentryReplayOptions: XCTestCase {
162162

163163
RNSentryReplay.updateOptions(optionsDict)
164164

165-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
165+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
166166

167167
XCTAssertEqual(actualOptions.sessionReplay.maskAllText, false)
168168
XCTAssertEqual(actualOptions.sessionReplay.maskedViewClasses.count, 0)
@@ -176,7 +176,7 @@ final class RNSentryReplayOptions: XCTestCase {
176176

177177
RNSentryReplay.updateOptions(optionsDict)
178178

179-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
179+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
180180

181181
XCTAssertTrue(actualOptions.sessionReplay.enableViewRendererV2)
182182
}
@@ -190,7 +190,7 @@ final class RNSentryReplayOptions: XCTestCase {
190190

191191
RNSentryReplay.updateOptions(optionsDict)
192192

193-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
193+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
194194

195195
XCTAssertTrue(actualOptions.sessionReplay.enableViewRendererV2)
196196
}
@@ -204,7 +204,7 @@ final class RNSentryReplayOptions: XCTestCase {
204204

205205
RNSentryReplay.updateOptions(optionsDict)
206206

207-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
207+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
208208

209209
XCTAssertFalse(actualOptions.sessionReplay.enableViewRendererV2)
210210
}
@@ -217,7 +217,7 @@ final class RNSentryReplayOptions: XCTestCase {
217217

218218
RNSentryReplay.updateOptions(optionsDict)
219219

220-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
220+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
221221

222222
XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering)
223223
}
@@ -231,7 +231,7 @@ final class RNSentryReplayOptions: XCTestCase {
231231

232232
RNSentryReplay.updateOptions(optionsDict)
233233

234-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
234+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
235235

236236
XCTAssertTrue(actualOptions.sessionReplay.enableFastViewRendering)
237237
}
@@ -245,7 +245,7 @@ final class RNSentryReplayOptions: XCTestCase {
245245

246246
RNSentryReplay.updateOptions(optionsDict)
247247

248-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
248+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
249249

250250
XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering)
251251
}
@@ -258,7 +258,7 @@ final class RNSentryReplayOptions: XCTestCase {
258258

259259
RNSentryReplay.updateOptions(optionsDict)
260260

261-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
261+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
262262

263263
XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
264264
}
@@ -272,7 +272,7 @@ final class RNSentryReplayOptions: XCTestCase {
272272

273273
RNSentryReplay.updateOptions(optionsDict)
274274

275-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
275+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
276276

277277
XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.low)
278278
}
@@ -286,7 +286,7 @@ final class RNSentryReplayOptions: XCTestCase {
286286

287287
RNSentryReplay.updateOptions(optionsDict)
288288

289-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
289+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
290290

291291
XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
292292
}
@@ -300,7 +300,7 @@ final class RNSentryReplayOptions: XCTestCase {
300300

301301
RNSentryReplay.updateOptions(optionsDict)
302302

303-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
303+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
304304

305305
XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.high)
306306
}
@@ -314,7 +314,7 @@ final class RNSentryReplayOptions: XCTestCase {
314314

315315
RNSentryReplay.updateOptions(optionsDict)
316316

317-
let actualOptions = try! Options(dict: optionsDict as! [String: Any])
317+
let actualOptions = try! SentryOptionsInternal.initWithDict(optionsDict as! [String: Any])
318318

319319
XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
320320
}

‎packages/core/ios/RNSentry.mm‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#import <Sentry/SentryDebugImageProvider+HybridSDKs.h>
2525
#import <Sentry/SentryDependencyContainer.h>
2626
#import <Sentry/SentryFormatter.h>
27-
#import <Sentry/SentryOptions+HybridSDKs.h>
27+
#import <Sentry/SentryOptionsInternal.h>
2828
#import <Sentry/SentryScreenFrames.h>
2929

3030
// This guard prevents importing Hermes in JSC apps
@@ -165,7 +165,7 @@ - (SentryOptions *_Nullable)createOptionsWithDictionary:(NSDictionary *_Nonnull)
165165
[RNSentryReplay updateOptions:mutableOptions];
166166
#endif
167167

168-
SentryOptions *sentryOptions = [[SentryOptions alloc] initWithDict:mutableOptions
168+
SentryOptions *sentryOptions = [SentryOptionsInternal initWithDict:mutableOptions
169169
didFailWithError:errorPointer];
170170
if (*errorPointer != nil) {
171171
return nil;

0 commit comments

Comments
 (0)