Skip to content

Commit 9d49612

Browse files
authored
Add better needs_web check to CI (#5863)
1 parent 39873ba commit 9d49612

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

.github/workflows/detect-changes.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ on:
5555
needs_sample_expo:
5656
description: 'Whether the Expo sample app workflow should run'
5757
value: ${{ jobs.changes.outputs.needs_sample_expo }}
58+
needs_web:
59+
description: 'Whether web jobs should run (sample builds)'
60+
value: ${{ jobs.changes.outputs.needs_web }}
5861

5962
jobs:
6063
changes:
@@ -74,6 +77,7 @@ jobs:
7477
needs_android: ${{ steps.evaluate.outputs.needs_android }}
7578
needs_sample_react_native: ${{ steps.evaluate.outputs.needs_sample_react_native }}
7679
needs_sample_expo: ${{ steps.evaluate.outputs.needs_sample_expo }}
80+
needs_web: ${{ steps.evaluate.outputs.needs_web }}
7781
steps:
7882
- uses: actions/checkout@v4
7983

@@ -168,3 +172,17 @@ jobs:
168172
echo "needs_sample_expo=false" >> "$GITHUB_OUTPUT"
169173
echo "=> needs_sample_expo=false"
170174
fi
175+
176+
# Web builds run when:
177+
# - JS source changed (the web bundle depends on it)
178+
# - CI config changed (need to validate workflows themselves)
179+
# - Push to main or release branch (always run everything)
180+
if [[ "$JS_SOURCE" == "true" \
181+
|| "$CI_CHANGED" == "true" \
182+
|| "$IS_MAIN_OR_RELEASE" == "true" ]]; then
183+
echo "needs_web=true" >> "$GITHUB_OUTPUT"
184+
echo "=> needs_web=true"
185+
else
186+
echo "needs_web=false" >> "$GITHUB_OUTPUT"
187+
echo "=> needs_web=false"
188+
fi

.github/workflows/sample-application-expo.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ jobs:
7373
elif [[ "${{ matrix.platform }}" == "android" && "${{ needs.detect-changes.outputs.needs_android }}" != "true" ]]; then
7474
echo "skip=true" >> "$GITHUB_OUTPUT"
7575
echo "Skipping Android — no relevant changes detected."
76-
elif [[ "${{ matrix.platform }}" == "web" && "${{ needs.detect-changes.outputs.js_source }}" != "true" ]]; then
76+
elif [[ "${{ matrix.platform }}" == "web" && "${{ needs.detect-changes.outputs.needs_web }}" != "true" ]]; then
7777
echo "skip=true" >> "$GITHUB_OUTPUT"
78-
echo "Skipping Web — no relevant JS changes detected."
78+
echo "Skipping Web — no relevant changes detected."
7979
fi
8080
8181
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

0 commit comments

Comments
 (0)