fix(e2e): Address review feedback

- Add platform-check skip guard to warm-up steps in both e2e-v2 and
  sample-application workflows to avoid wasting CI time when skipped
- Write maestro debug logs to per-flow/per-attempt dirs so failed
  attempt logs are preserved for debugging
- Use path.parse() for flow name extraction
- Add empty results guard in cli.mjs
- Remove retry logic from sample app maestro.ts to avoid mock server
  envelope accumulation across retries (retries stay in cli.mjs only)
- Revert unrelated expo/app.json formatting change

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: antonis

.github/workflows/e2e-v2.yml

@@ -517,7 +517,7 @@ jobs:
           erase_before_boot: false
 
       - name: Warm up iOS simulator
-        if: ${{ matrix.platform == 'ios' }}
+        if: ${{ steps.platform-check.outputs.skip != 'true' && matrix.platform == 'ios' }}
         run: |
           # Tart VMs are very slow right after boot.  Launch a stock app so
           # that SpringBoard, backboardd, and other system services finish

.github/workflows/sample-application.yml

@@ -362,7 +362,7 @@ jobs:
           erase_before_boot: false
 
       - name: Warm up iOS Simulator
-        if: ${{ matrix.platform == 'ios' }}
+        if: ${{ steps.platform-check.outputs.skip != 'true' && matrix.platform == 'ios' }}
         run: |
           # Tart VMs are very slow right after boot.  Launch a stock app so
           # that SpringBoard, backboardd, and other system services finish

dev-packages/e2e-tests/cli.mjs

@@ -302,7 +302,7 @@ if (actions.includes('test')) {
 
     try {
       for (const flowFile of flowFiles) {
-        const flowName = flowFile.replace('.yml', '');
+        const flowName = path.parse(flowFile).name;
         let passed = false;
 
         for (let attempt = 1; attempt <= maxAttempts; attempt++) {
@@ -313,7 +313,7 @@ if (actions.includes('test')) {
               'test', `maestro/${flowFile}`,
               '--env', `APP_ID=${appId}`,
               '--env', `SENTRY_AUTH_TOKEN=${sentryAuthToken}`,
-              '--debug-output', 'maestro-logs',
+              '--debug-output', `maestro-logs/${flowName}/attempt-${attempt}`,
               '--flatten-debug-output',
             ], {
               stdio: 'inherit',
@@ -360,6 +360,11 @@ if (actions.includes('test')) {
       if (!passed) failed.push(flowName);
     }
 
+    if (results.length === 0) {
+      console.error('No test results collected — flow discovery may have failed');
+      process.exit(1);
+    }
+
     if (failed.length > 0) {
       console.error(`\n${failed.length}/${results.length} flows failed after ${maxAttempts} attempts: ${failed.join(', ')}`);
       process.exit(1);

samples/expo/app.json

@@ -13,7 +13,9 @@
       "resizeMode": "contain",
       "backgroundColor": "#ffffff"
     },
-    "assetBundlePatterns": ["**/*"],
+    "assetBundlePatterns": [
+      "**/*"
+    ],
     "ios": {
       "supportsTablet": true,
       "bundleIdentifier": "io.sentry.expo.sample",
@@ -106,4 +108,4 @@
       "url": "https://u.expo.dev/00000000-0000-0000-0000-000000000000"
     }
   }
-}
+}

samples/react-native/e2e/utils/maestro.ts

@@ -1,12 +1,13 @@
 import { spawn } from 'node:child_process';
 import path from 'node:path';
 
-const MAX_RETRIES = 3;
-
 /**
- * Run a single Maestro test attempt.
+ * Run a Maestro test and return a promise that resolves when the test is finished.
+ *
+ * @param test - The path to the Maestro test file relative to the `e2e` directory.
+ * @returns A promise that resolves when the test is finished.
  */
-const runMaestro = (test: string): Promise<void> => {
+export const maestro = async (test: string) => {
   return new Promise((resolve, reject) => {
     const process = spawn('maestro', ['test', test, '--format', 'junit'], {
       cwd: path.join(__dirname, '..'),
@@ -21,29 +22,3 @@ const runMaestro = (test: string): Promise<void> => {
     });
   });
 };
-
-/**
- * Run a Maestro test with retries to handle transient app crashes on slow CI VMs.
- *
- * Note: Retries happen at the Maestro flow level. If a failed attempt sends partial
- * envelopes to the mock server before crashing, they will accumulate across retries.
- * In practice, crashes occur on app launch before any SDK transactions are sent,
- * so this does not cause issues with test assertions.
- *
- * @param test - The path to the Maestro test file relative to the `e2e` directory.
- * @returns A promise that resolves when the test passes.
- */
-export const maestro = async (test: string) => {
-  for (let attempt = 1; attempt <= MAX_RETRIES; attempt++) {
-    try {
-      await runMaestro(test);
-      return;
-    } catch (error) {
-      if (attempt < MAX_RETRIES) {
-        console.warn(`Maestro attempt ${attempt}/${MAX_RETRIES} failed, retrying...`);
-      } else {
-        throw error;
-      }
-    }
-  }
-};