fix(android): Properly remove duplicated breadcrumbs (#5841)

* fix(android): Properly remove duplicated breadcrumbs

This should fix duplicated breadcrumbs on Android.
- Sentry syncs breadcrumbs from JS and native
- In the past JS breadcrumbs was filtered out before sent to JS side
- This filter worked on iterator of native Scope and broke when Native Android SDK replaces raw Scope with some composite scope class which plays role of "view" to sevral downstream Scope objects
- This patch change filter to work on materialized breadcrumbs array just after serialization

* chore: use proper generic types

* chore: make linter happy as suggested

* chore: make linter even happier

* chore: finally fix java formatting

* chore: rewrite filtering algorithm to be more resilent to crashes

- use runtime type checks where possible without reducing perf
- use only features of java 8 so our tests can pass

Author: vovkasm

packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

@@ -28,7 +28,6 @@
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.bridge.WritableNativeArray;
 import com.facebook.react.bridge.WritableNativeMap;
-import io.sentry.Breadcrumb;
 import io.sentry.ILogger;
 import io.sentry.IScope;
 import io.sentry.ISentryExecutorService;
@@ -73,7 +72,6 @@
 import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.HashMap;
-import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -866,19 +864,25 @@ protected void fetchNativeDeviceContexts(
       promise.resolve(null);
       return;
     }
-    if (currentScope != null) {
-      // Remove react-native breadcrumbs
-      Iterator<Breadcrumb> breadcrumbsIterator = currentScope.getBreadcrumbs().iterator();
-      while (breadcrumbsIterator.hasNext()) {
-        Breadcrumb breadcrumb = breadcrumbsIterator.next();
-        if ("react-native".equals(breadcrumb.getOrigin())) {
-          breadcrumbsIterator.remove();
+
+    final @NotNull Map<String, Object> serialized =
+        InternalSentrySdk.serializeScope(context, (SentryAndroidOptions) options, currentScope);
+
+    final @Nullable Object serializedBreadcrumbs = serialized.get("breadcrumbs");
+    if (serializedBreadcrumbs instanceof List) {
+      final List<?> breadcrumbs = (List<?>) serializedBreadcrumbs;
+      List<Map<?, ?>> filtered = new ArrayList<>();
+      for (Object o : breadcrumbs) {
+        if (o instanceof Map) {
+          final Map<?, ?> breadcrumb = (Map<?, ?>) o;
+          if (!"react-native".equals(breadcrumb.get("origin"))) {
+            filtered.add(breadcrumb);
+          }
         }
       }
+      serialized.put("breadcrumbs", filtered);
     }
 
-    final @NotNull Map<String, Object> serialized =
-        InternalSentrySdk.serializeScope(context, (SentryAndroidOptions) options, currentScope);
     final @Nullable Object deviceContext = RNSentryMapConverter.convertToWritable(serialized);
     promise.resolve(deviceContext);
   }