Skip to content

Commit c75ac51

Browse files
antonisclaude
andauthored
chore(core): Deprecate FeedbackButton FAB APIs (#5933)
* refactor(core): Rename FeedbackWidget to FeedbackForm Deprecate "widget" term in favor of "form" to align with the broader Sentry SDK ecosystem naming convention. All public APIs are preserved as deprecated aliases: - FeedbackWidget → FeedbackForm - showFeedbackWidget → showFeedbackForm - FeedbackWidgetProps → FeedbackFormProps - FeedbackWidgetStyles → FeedbackFormStyles - FeedbackWidgetState → FeedbackFormState - FeedbackWidgetTheme → FeedbackFormTheme - FeedbackWidgetManager → FeedbackFormManager Closes #5892 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test(core): Add backward compatibility tests for deprecated FeedbackWidget API Verify that the deprecated FeedbackWidget and showFeedbackWidget exports are identical to their FeedbackForm replacements. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs(changelog): Add FeedbackWidget to FeedbackForm rename entry Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore(core): Deprecate FeedbackButton, showFeedbackButton, and hideFeedbackButton Mark the floating action button (FAB) APIs as deprecated. They will be removed in a future major version. Closes #5893 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs(changelog): Add FeedbackButton deprecation entry Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix lint issue --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent dfdd377 commit c75ac51

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
- Rename `FeedbackWidget` to `FeedbackForm` and `showFeedbackWidget` to `showFeedbackForm` ([#5931](https://github.com/getsentry/sentry-react-native/pull/5931))
1414
- The old names are deprecated but still work
15+
- Deprecate `FeedbackButton`, `showFeedbackButton`, and `hideFeedbackButton` ([#5933](https://github.com/getsentry/sentry-react-native/pull/5933))
1516

1617
### Fixes
1718

packages/core/src/js/feedback/FeedbackButton.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { lazyLoadFeedbackIntegration } from './lazy';
1414

1515
/**
1616
* @beta
17+
* @deprecated The `FeedbackButton` component will be removed in a future major version.
1718
* Implements a feedback button that opens the FeedbackForm.
1819
*/
1920
export class FeedbackButton extends React.Component<FeedbackButtonProps> {

packages/core/src/js/feedback/FeedbackFormManager.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,13 @@ const showFeedbackWidget = showFeedbackForm;
122122
/** @deprecated Use `resetFeedbackFormManager` instead. */
123123
const resetFeedbackWidgetManager = resetFeedbackFormManager;
124124

125+
/** @deprecated `showFeedbackButton` will be removed in a future major version. */
125126
const showFeedbackButton = (): void => {
126127
lazyLoadAutoInjectFeedbackButtonIntegration();
127128
FeedbackButtonManager.show();
128129
};
129130

131+
/** @deprecated `hideFeedbackButton` will be removed in a future major version. */
130132
const hideFeedbackButton = (): void => {
131133
FeedbackButtonManager.hide();
132134
};

packages/core/src/js/index.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,14 @@ export type { TimeToDisplayProps, ExpoRouter, ExpoImage, ExpoAsset } from './tra
101101

102102
export { Mask, Unmask } from './replay/CustomMask';
103103

104+
/** @deprecated The `FeedbackButton` component will be removed in a future major version. */
104105
export { FeedbackButton } from './feedback/FeedbackButton';
105106
export { FeedbackForm } from './feedback/FeedbackForm';
106-
export {
107-
showFeedbackForm,
108-
showFeedbackButton,
109-
hideFeedbackButton,
110-
enableFeedbackOnShake,
111-
disableFeedbackOnShake,
112-
} from './feedback/FeedbackFormManager';
107+
export { showFeedbackForm, enableFeedbackOnShake, disableFeedbackOnShake } from './feedback/FeedbackFormManager';
108+
/** @deprecated `showFeedbackButton` will be removed in a future major version. */
109+
export { showFeedbackButton } from './feedback/FeedbackFormManager';
110+
/** @deprecated `hideFeedbackButton` will be removed in a future major version. */
111+
export { hideFeedbackButton } from './feedback/FeedbackFormManager';
113112

114113
/** @deprecated Use `FeedbackForm` instead. */
115114
export { FeedbackForm as FeedbackWidget } from './feedback/FeedbackForm';

0 commit comments

Comments
 (0)