chore(deps): Bump E2E tests to 0.84.0 (#5492)

* chore(deps): Bump E2E tests to 0.83.1

* Bump to 0.84.0-rc.0

* Fix Build RN 0.84.0-rc.0 legacy hermes ios production dynamic

* Iterate on the fix

* Update React Native version to 0.84.0-rc.1

* Bump to 0.84.0-rc.3

* Bump to 0.84.0-rc.4

* Update React Native version from rc.4 to rc.5

* Bump to 0.84.0

* fix(e2e): Use install_modules_dependencies for react-native-launch-arguments

Enhances the patch script to use install_modules_dependencies() instead
of hardcoded React/React-Core dependencies. This is the modern approach
for React Native 0.60+ that properly handles all framework configurations
(static, dynamic, etc.) and automatically resolves the correct React Native
dependencies.

This should fix the "Undefined symbols: _RCTRegisterModule" error when
building RN 0.84.0 with dynamic frameworks on iOS.

The patch now uses the same defensive pattern as RNSentry.podspec, with
a fallback to React-Core for older RN versions that don't have
install_modules_dependencies defined.

Tested locally and verified:
- Patch successfully replaces s.dependency "React"
- Generated Ruby syntax is valid
- Idempotent (safe to run multiple times)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: antonis

.github/workflows/e2e-v2.yml

@@ -189,7 +189,7 @@ jobs:
     strategy:
       fail-fast: false # keeps matrix running if one fails
       matrix:
-        rn-version: ['0.71.19', '0.83.0']
+        rn-version: ['0.71.19', '0.84.0']
         rn-architecture: ['legacy', 'new']
         platform: ['android', 'ios']
         build-type: ['production']
@@ -202,13 +202,13 @@ jobs:
             runs-on: ["ghcr.io/cirruslabs/macos-sequoia-xcode:16.4", "runner_group_id:12"]
           # Use Xcode 26 for newer RN versions (0.83.0)
           - platform: ios
-            rn-version: '0.83.0'
+            rn-version: '0.84.0'
             runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2.0", "runner_group_id:12"]
           - platform: android
             runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:12"]
         exclude:
           # exclude JSC for new RN versions (keeping the matrix manageable)
-          - rn-version: '0.83.0'
+          - rn-version: '0.84.0'
             engine: 'jsc'
           # exclude all rn versions lower than 0.80.0 for new architecture
           - rn-version: '0.71.19'
@@ -323,15 +323,15 @@ jobs:
     strategy:
       fail-fast: false # keeps matrix running if one fails
       matrix:
-        rn-version: ['0.83.0']
+        rn-version: ['0.84.0']
         rn-architecture: ['legacy', 'new']
         platform: ['android', 'ios']
         build-type: ['production']
         ios-use-frameworks: ['no'] # test only no frameworks
         engine: ['hermes']
         include:
           - platform: ios
-            rn-version: '0.83.0'
+            rn-version: '0.84.0'
             runs-on:  macos-26
           - platform: android
             runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:12"]

dev-packages/e2e-tests/cli.mjs

@@ -156,7 +156,7 @@ if (actions.includes('create')) {
     env: Object.assign(env, { YARN_ENABLE_IMMUTABLE_INSTALLS: false }),
   });
 
-  // Patch react-native-launch-arguments for Gradle 9+ compatibility
+  // Patch react-native-launch-arguments for Gradle 9+ compatibility (Android) and React Native 0.84+ compatibility (iOS)
   execSync(`${patchScriptsDir}/rn.patch.launch-arguments.js --app-dir .`, {
     stdio: 'inherit',
     cwd: appDir,
@@ -189,6 +189,14 @@ if (actions.includes('create')) {
       env: env,
     });
 
+    // Clean Pods to ensure CocoaPods reads the patched podspec
+    if (fs.existsSync(`${appDir}/ios/Pods`)) {
+      fs.rmSync(`${appDir}/ios/Pods`, { recursive: true });
+    }
+    if (fs.existsSync(`${appDir}/ios/Podfile.lock`)) {
+      fs.rmSync(`${appDir}/ios/Podfile.lock`);
+    }
+
     if (fs.existsSync(`${appDir}/Gemfile`)) {
       execSync(`bundle install`, { stdio: 'inherit', cwd: appDir, env: env });
       execSync('bundle exec pod install --repo-update', { stdio: 'inherit', cwd: `${appDir}/ios`, env: env });

dev-packages/e2e-tests/patch-scripts/rn.patch.launch-arguments.js

@@ -25,22 +25,79 @@ debug.log('Patching react-native-launch-arguments build.gradle', buildGradlePath
 
 if (!fs.existsSync(buildGradlePath)) {
   debug.log('build.gradle not found, skipping patch');
-  return;
+} else {
+  const buildGradle = fs.readFileSync(buildGradlePath, 'utf8');
+
+  // Replace destinationDir with destinationDirectory.get() for Gradle 9+ compatibility
+  const isPatched = buildGradle.includes('destinationDirectory.get()');
+  if (!isPatched) {
+    const patched = buildGradle.replace(
+      /\.destinationDir\b/g,
+      '.destinationDirectory.get()'
+    );
+
+    fs.writeFileSync(buildGradlePath, patched);
+    debug.log('Patched react-native-launch-arguments build.gradle successfully!');
+  } else {
+    debug.log('react-native-launch-arguments build.gradle is already patched!');
+  }
 }
 
-const buildGradle = fs.readFileSync(buildGradlePath, 'utf8');
+// Patch iOS podspec for React Native 0.71+ compatibility
+// Replace 'React' with install_modules_dependencies() to fix RCTRegisterModule undefined symbol error in RN 0.84+ with dynamic frameworks
+const podspecPath = path.join(
+  args['app-dir'],
+  'node_modules',
+  'react-native-launch-arguments',
+  'react-native-launch-arguments.podspec'
+);
+
+debug.log('Patching react-native-launch-arguments podspec', podspecPath);
+
+if (fs.existsSync(podspecPath)) {
+  const podspec = fs.readFileSync(podspecPath, 'utf8');
+  debug.log('Found podspec, checking for React dependency...');
+
+  // Check if already patched with install_modules_dependencies
+  const isPatched = podspec.includes('install_modules_dependencies');
+  const hasReactDep = /s\.dependency\s+['"]React['"]/.test(podspec);
+  const hasReactCoreDep = /s\.dependency\s+['"]React\/Core['"]/.test(podspec);
+  const hasReactCoreDepOnly = podspec.includes("s.dependency 'React-Core'") || podspec.includes('s.dependency "React-Core"');
+
+  debug.log(`Podspec status: isPatched=${isPatched}, hasReactDep=${hasReactDep}, hasReactCoreDep=${hasReactCoreDep}, hasReactCoreDepOnly=${hasReactCoreDepOnly}`);
+
+  if (!isPatched && (hasReactDep || hasReactCoreDep || hasReactCoreDepOnly)) {
+    let patched = podspec;
+
+    // Replace any React dependency with install_modules_dependencies(s)
+    // This is the modern approach that works with all framework configurations (static, dynamic, etc.)
+    // and automatically includes the correct React Native dependencies
+    const installModulesDepsBlock = `
+  if defined? install_modules_dependencies
+    install_modules_dependencies(s)
+  else
+    s.dependency "React-Core"
+  end`;
 
-// Replace destinationDir with destinationDirectory.get() for Gradle 9+ compatibility
-const isPatched = buildGradle.includes('destinationDirectory.get()');
-if (!isPatched) {
-  const patched = buildGradle.replace(
-    /\.destinationDir\b/g,
-    '.destinationDirectory.get()'
-  );
+    if (hasReactDep) {
+      debug.log("Replacing s.dependency 'React' with install_modules_dependencies(s)");
+      patched = patched.replace(/\s+s\.dependency\s+['"]React['"]\s*\n/g, installModulesDepsBlock + '\n');
+    } else if (hasReactCoreDep) {
+      debug.log("Replacing s.dependency 'React/Core' with install_modules_dependencies(s)");
+      patched = patched.replace(/\s+s\.dependency\s+['"]React\/Core['"]\s*\n/g, installModulesDepsBlock + '\n');
+    } else if (hasReactCoreDepOnly) {
+      debug.log("Replacing s.dependency 'React-Core' with install_modules_dependencies(s)");
+      patched = patched.replace(/\s+s\.dependency\s+['"]React-Core['"]\s*\n/g, installModulesDepsBlock + '\n');
+    }
 
-  fs.writeFileSync(buildGradlePath, patched);
-  debug.log('Patched react-native-launch-arguments build.gradle successfully!');
+    fs.writeFileSync(podspecPath, patched);
+    debug.log('Patched react-native-launch-arguments podspec successfully!');
+  } else if (isPatched) {
+    debug.log('react-native-launch-arguments podspec is already patched!');
+  } else {
+    debug.log('Podspec does not contain React dependency - may already use install_modules_dependencies');
+  }
 } else {
-  debug.log('react-native-launch-arguments build.gradle is already patched!');
+  debug.log('podspec not found, skipping iOS patch');
 }