Commit d39dbda
committed
fix(core): Fix initial span and orphaned span handling with useDispatchedActionData
Two fixes based on PR review feedback:
1. Allow setup/programmatic calls (no event) to create the initial
navigation span even when useDispatchedActionData is enabled. The
early return for actions without payload.name now checks that an
event exists, so afterAllSetup and registerNavigationContainer
still work correctly.
2. Pass the actual span name to ignoreEmptyRouteChangeTransactions
instead of the hardcoded default. This ensures orphaned spans
created with a dispatched route name are still discarded when
the state listener is never called.1 parent dcfe90c commit d39dbda
2 files changed
Lines changed: 49 additions & 7 deletions
File tree
- packages/core
- src/js/tracing
- test/tracing
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | | - | |
| 382 | + | |
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
| |||
409 | 409 | | |
410 | 410 | | |
411 | 411 | | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
| 412 | + | |
| 413 | + | |
418 | 414 | | |
419 | 415 | | |
420 | 416 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1058 | 1058 | | |
1059 | 1059 | | |
1060 | 1060 | | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
| 1079 | + | |
| 1080 | + | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
1061 | 1107 | | |
1062 | 1108 | | |
1063 | 1109 | | |
| |||
0 commit comments