Skip to content

Commit dadeb89

Browse files
antonisclaude
andcommitted
fix(core): Fix tsconfig resolution and Detox R8 error for RN 0.84
- Use bare specifier in tsconfig extends (`@react-native/typescript-config` instead of `@react-native/typescript-config/tsconfig.json`). Node 22 strictly enforces the package's `exports` field, and ts-jest couldn't resolve the direct file path. - Add proguard `-dontwarn` for `NotThreadSafeBridgeIdleDebugListener` which Detox references but was removed in RN 0.84. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 1f23e0f commit dadeb89

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

samples/react-native/android/app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ android {
190190
signingConfig signingConfigs.debug
191191
minifyEnabled enableProguardInReleaseBuilds
192192
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
193+
testProguardFiles "proguard-rules.pro"
193194
proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro"
194195
}
195196
}

samples/react-native/android/app/proguard-rules.pro

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@
1212
# Detox Release tests were failing on missing kotlin.Result
1313
# It should be covered by node_modules/detox/android/detox/proguard-rules-app.pro but it seems missing
1414
-keep class kotlin.** { *; }
15+
16+
# Detox references bridge classes removed in RN 0.84
17+
-dontwarn com.facebook.react.bridge.NotThreadSafeBridgeIdleDebugListener

samples/react-native/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// prettier-ignore
22
{
3-
"extends": "@react-native/typescript-config/tsconfig.json",
3+
"extends": "@react-native/typescript-config",
44
"compilerOptions": {
55
/* Visit https://aka.ms/tsconfig.json to read more about this file */
66

0 commit comments

Comments
 (0)