Skip to content

Commit ddfeed8

Browse files
committed
Updated performance test approach
1 parent c67ca9d commit ddfeed8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/detect-changes.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
JS_SOURCE: ${{ steps.filter.outputs.js_source }}
6565
CI_CHANGED: ${{ steps.filter.outputs.ci }}
6666
E2E_TESTS: ${{ steps.filter.outputs.e2e_tests }}
67-
PERF_TESTS: ${{ steps.filter.outputs.perf_tests }}
6867
IS_MAIN_OR_RELEASE: ${{ github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/')) }}
6968
run: |
7069
echo "--- Change Detection Summary ---"
@@ -73,20 +72,20 @@ jobs:
7372
echo "js_source=$JS_SOURCE"
7473
echo "ci=$CI_CHANGED"
7574
echo "e2e_tests=$E2E_TESTS"
76-
echo "perf_tests=$PERF_TESTS"
7775
echo "is_main_or_release=$IS_MAIN_OR_RELEASE"
7876
7977
# iOS is needed if:
8078
# - iOS native code changed
8179
# - JS source changed (may affect native bridges)
8280
# - CI config changed (need to validate workflows)
83-
# - E2E or perf tests changed (they test both platforms)
81+
# - E2E tests changed (they test both platforms end-to-end)
8482
# - Push to main or release branch (always run everything)
83+
# Note: perf_tests changes only affect the `metrics` job in e2e-v2.yml,
84+
# not the native test suites or sample app builds.
8585
if [[ "$IOS_NATIVE" == "true" \
8686
|| "$JS_SOURCE" == "true" \
8787
|| "$CI_CHANGED" == "true" \
8888
|| "$E2E_TESTS" == "true" \
89-
|| "$PERF_TESTS" == "true" \
9089
|| "$IS_MAIN_OR_RELEASE" == "true" ]]; then
9190
echo "needs_ios=true" >> "$GITHUB_OUTPUT"
9291
echo "=> needs_ios=true"
@@ -99,13 +98,14 @@ jobs:
9998
# - Android native code changed
10099
# - JS source changed (may affect native bridges)
101100
# - CI config changed (need to validate workflows)
102-
# - E2E or perf tests changed (they test both platforms)
101+
# - E2E tests changed (they test both platforms end-to-end)
103102
# - Push to main or release branch (always run everything)
103+
# Note: perf_tests changes only affect the `metrics` job in e2e-v2.yml,
104+
# not the native test suites or sample app builds.
104105
if [[ "$ANDROID_NATIVE" == "true" \
105106
|| "$JS_SOURCE" == "true" \
106107
|| "$CI_CHANGED" == "true" \
107108
|| "$E2E_TESTS" == "true" \
108-
|| "$PERF_TESTS" == "true" \
109109
|| "$IS_MAIN_OR_RELEASE" == "true" ]]; then
110110
echo "needs_android=true" >> "$GITHUB_OUTPUT"
111111
echo "=> needs_android=true"

0 commit comments

Comments
 (0)