fix(ios): Fix podspec compiler flags being overridden by install_modules_dependencies

`s.compiler_flags` was silently overridden by `install_modules_dependencies()`,
so `-DSENTRY_PROFILING_SUPPORTED`, `-DNEW_HERMES_RUNTIME`, and
`-DRCT_NEW_ARCH_ENABLED` were never applied. Add flags to
`pod_target_xcconfig['OTHER_CFLAGS']` which takes effect correctly.

Also set `REACT_NATIVE_NODE_MODULES_DIR` in the sample app's Podfile
and pod-install script so the podspec detects the app's RN version
instead of the SDK's devDependency version in the monorepo.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: antonis

packages/core/RNSentry.podspec

@@ -48,7 +48,8 @@ Pod::Spec.new do |s|
 
   s.pod_target_xcconfig = {
     'DEFINES_MODULE' => 'YES',
-    'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"'
+    'HEADER_SEARCH_PATHS' => '$(inherited) "${PODS_ROOT}/Sentry/Sources/Sentry" "${PODS_ROOT}/Sentry/Sources/Sentry/include"',
+    'OTHER_CFLAGS' => other_cflags
   }
 
   s.dependency 'Sentry', '9.8.0'

samples/react-native/ios/Podfile

@@ -5,6 +5,10 @@ require Pod::Executable.execute_command('node', ['-p',
     {paths: [process.argv[1]]},
   )', __dir__]).strip
 
+# In the monorepo, the SDK podspec resolves react-native to its own devDependency.
+# Point it to the sample app's react-native so it detects the correct version for build flags.
+ENV['REACT_NATIVE_NODE_MODULES_DIR'] ||= File.expand_path(File.join(__dir__, '..', 'node_modules', 'react-native'))
+
 platform :ios, min_ios_version_supported
 prepare_react_native_project!
 

samples/react-native/scripts/pod-install.sh

@@ -12,6 +12,10 @@ echo "ENABLE_NEW_ARCH=$ENABLE_NEW_ARCH"
 cd "${thisFilePath}/.."
 bundle install
 
+# In the monorepo, the SDK's packages/core resolves react-native to its own devDependency version.
+# We need to point the podspec to the sample app's react-native so it detects the correct version.
+export REACT_NATIVE_NODE_MODULES_DIR="${PWD}/node_modules/react-native"
+
 cd ios
 PRODUCTION=$ENABLE_PROD RCT_NEW_ARCH_ENABLED=$ENABLE_NEW_ARCH bundle exec pod update