Sentry wizard will break RN from 81.1

[sharifhh]

Description

Hello

FYI, a change in with_environment script will break your script for auto upload in iOS - I tried to find a quick solution but couldn't so I just patched the new script to revert "$1" back to $1

would love if you find a better way to have your script after this change.

Thanks

PR that broke: facebook/react-native#53194

[linear]

RN-314 Sentry wizard will break RN from 81.1

[kahest]

Thanks @sharifhh for letting us know - so if I understand correctly, you worked around this by reverting the change in this line?

[carl-sauter]

Thanks @sharifhh for letting us know - so if I understand correctly, you worked around this by reverting the change in this line?

Works for me. But an official fix would be great. If anyone needs a patch file:

diff --git a/scripts/xcode/with-environment.sh b/scripts/xcode/with-environment.sh
index d2ddf3c02cabb41d1dea7b3c6de2785df696524e..c6bd62c87fc811077c882070ef71533d4fe781cf 100755
--- a/scripts/xcode/with-environment.sh
+++ b/scripts/xcode/with-environment.sh
@@ -43,5 +43,5 @@ fi
 
 # Execute argument, if present
 if [ -n "$1" ]; then
-  "$1"
+  $1
 fi

[sharifhh]

@kahest yup yup, just removed the double quote as @Kinqdos shared

[frompton]

Hi, just to chime in, we encountered this problem in one of our apps today, but another app worked with the same versions of everything. Removing the double quotes worked for us but felt bad for maintainability, so we tried comparing the two apps and realized we had missed something when upgrading react native many versions ago (between react native 0.73 and 0.74)

in: ios/RnDiffApp.xcodeproj/project.pbxproj

We had this:

shellScript = "set -e\n\nWITH_ENVIRONMENT=\"../node_modules/react-native/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"../node_modules/react-native/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n";

and it should be this

shellScript = "set -e\n\nWITH_ENVIRONMENT=\"$REACT_NATIVE_PATH/scripts/xcode/with-environment.sh\"\nREACT_NATIVE_XCODE=\"$REACT_NATIVE_PATH/scripts/react-native-xcode.sh\"\n\n/bin/sh -c \"$WITH_ENVIRONMENT $REACT_NATIVE_XCODE\"\n";

It solved the problem for us and worked with the double quotes version, so it might be worth checking!