From 8f57a65fe9e1b3d105b9148c035e2c2b51535ffd Mon Sep 17 00:00:00 2001 From: lucas Date: Tue, 20 May 2025 15:13:12 -0300 Subject: [PATCH 1/4] bump cocoa sdk --- CHANGELOG.md | 10 ++++++++++ packages/core/RNSentry.podspec | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 243284c499..47195a349e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,16 @@ > make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first. + +## Unreleased + +### Dependencies + +- Bump Cocoa SDK from v8.50.2 to v8.51.0 ([#??](https://github.com/getsentry/sentry-react-native/pull/??)) + - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8510) + - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.50.0...8.51.0) + + ## 7.0.0-alpha.0 ### Upgrading from 6.x to 7.0 diff --git a/packages/core/RNSentry.podspec b/packages/core/RNSentry.podspec index ff50ffeed2..715b60bd8f 100644 --- a/packages/core/RNSentry.podspec +++ b/packages/core/RNSentry.podspec @@ -37,7 +37,7 @@ Pod::Spec.new do |s| s.compiler_flags = other_cflags - s.dependency 'Sentry/HybridSDK', '8.50.0' + s.dependency 'Sentry/HybridSDK', '8.51.0' if defined? install_modules_dependencies # Default React Native dependencies for 0.71 and above (new and legacy architecture) From 061b810f9c16e53e5d6be9083f7d75a977eeae7b Mon Sep 17 00:00:00 2001 From: lucas Date: Tue, 20 May 2025 15:13:59 -0300 Subject: [PATCH 2/4] changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 47195a349e..f0347d4301 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ ### Dependencies -- Bump Cocoa SDK from v8.50.2 to v8.51.0 ([#??](https://github.com/getsentry/sentry-react-native/pull/??)) +- Bump Cocoa SDK from v8.50.2 to v8.51.0 ([#4843](https://github.com/getsentry/sentry-react-native/pull/4843)) - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8510) - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.50.0...8.51.0) From cd7e02a27ea391f3e7457bfd5253b466e433f511 Mon Sep 17 00:00:00 2001 From: LucasZF Date: Mon, 26 May 2025 11:55:41 +0100 Subject: [PATCH 3/4] Apply suggestions from code review --- CHANGELOG.md | 6 +++--- packages/core/RNSentry.podspec | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f0347d4301..05ebb305b1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,9 +11,9 @@ ### Dependencies -- Bump Cocoa SDK from v8.50.2 to v8.51.0 ([#4843](https://github.com/getsentry/sentry-react-native/pull/4843)) - - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8510) - - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.50.0...8.51.0) +- Bump Cocoa SDK from v8.50.2 to v8.51.1 ([#4843](https://github.com/getsentry/sentry-react-native/pull/4843)) + - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8511) + - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.50.0...8.51.1) ## 7.0.0-alpha.0 diff --git a/packages/core/RNSentry.podspec b/packages/core/RNSentry.podspec index 715b60bd8f..070de46982 100644 --- a/packages/core/RNSentry.podspec +++ b/packages/core/RNSentry.podspec @@ -37,7 +37,7 @@ Pod::Spec.new do |s| s.compiler_flags = other_cflags - s.dependency 'Sentry/HybridSDK', '8.51.0' + s.dependency 'Sentry/HybridSDK', '8.51.1' if defined? install_modules_dependencies # Default React Native dependencies for 0.71 and above (new and legacy architecture) From db4cfa2396c60ab6fde61bd479d42f352fa086ff Mon Sep 17 00:00:00 2001 From: lucas Date: Mon, 26 May 2025 09:55:37 -0300 Subject: [PATCH 4/4] Update default value test to align with the latest SDK --- .../RNSentryReplayOptionsTests.swift | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift index 4d94dba446..b23fac94e2 100644 --- a/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift +++ b/packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift @@ -166,7 +166,7 @@ final class RNSentryReplayOptions: XCTestCase { XCTAssertEqual(actualOptions.sessionReplay.maskAllText, false) XCTAssertEqual(actualOptions.sessionReplay.maskedViewClasses.count, 0) } - + func testEnableExperimentalViewRendererDefault() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567", @@ -177,9 +177,9 @@ final class RNSentryReplayOptions: XCTestCase { let actualOptions = try! Options(dict: optionsDict as! [String: Any]) - XCTAssertFalse(actualOptions.sessionReplay.enableExperimentalViewRenderer) + XCTAssertTrue(actualOptions.sessionReplay.enableExperimentalViewRenderer) } - + func testEnableExperimentalViewRendererTrue() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567", @@ -193,7 +193,7 @@ final class RNSentryReplayOptions: XCTestCase { XCTAssertTrue(actualOptions.sessionReplay.enableExperimentalViewRenderer) } - + func testEnableExperimentalViewRendererFalse() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567", @@ -207,7 +207,7 @@ final class RNSentryReplayOptions: XCTestCase { XCTAssertFalse(actualOptions.sessionReplay.enableExperimentalViewRenderer) } - + func testEnableFastViewRenderingDefault() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567", @@ -220,7 +220,7 @@ final class RNSentryReplayOptions: XCTestCase { XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering) } - + func testEnableFastViewRenderingTrue() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567", @@ -234,7 +234,7 @@ final class RNSentryReplayOptions: XCTestCase { XCTAssertTrue(actualOptions.sessionReplay.enableFastViewRendering) } - + func testEnableFastViewRenderingFalse() { let optionsDict = ([ "dsn": "https://abc@def.ingest.sentry.io/1234567",