Skip to content

DRAFT: Test with QOS_CLASS Priority#4848

Closed
antonis wants to merge 7 commits into
deps/scripts/update-cocoa.shfrom
antonis/test-dispathc-qo-class
Closed

DRAFT: Test with QOS_CLASS Priority#4848
antonis wants to merge 7 commits into
deps/scripts/update-cocoa.shfrom
antonis/test-dispathc-qo-class

Conversation

@antonis
Copy link
Copy Markdown
Contributor

@antonis antonis commented May 21, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Test with getsentry/sentry-cocoa@main...antonis/test-dispathc-qo-class

📜 Description

💡 Motivation and Context

#4839 (comment)

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.72 ms 392.21 ms -11.51 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
7140a40 664.39 ms 656.44 ms -7.95 ms
1dfac94 420.94 ms 408.17 ms -12.77 ms
12e4be5 433.46 ms 417.33 ms -16.13 ms
6492e76 424.30 ms 414.10 ms -10.20 ms
438739d 442.02 ms 457.96 ms 15.94 ms
3620199 402.58 ms 399.48 ms -3.10 ms
ef18299 429.64 ms 466.56 ms 36.92 ms
a9355d1 488.72 ms 557.00 ms 68.28 ms
4a86286 414.04 ms 415.15 ms 1.11 ms
6858e4c 421.02 ms 417.54 ms -3.48 ms

App size

Revision Plain With Sentry Diff
7140a40 17.74 MiB 20.08 MiB 2.35 MiB
1dfac94 17.75 MiB 20.13 MiB 2.38 MiB
12e4be5 17.75 MiB 20.12 MiB 2.37 MiB
6492e76 17.75 MiB 20.13 MiB 2.38 MiB
438739d 17.75 MiB 20.11 MiB 2.37 MiB
3620199 17.75 MiB 20.13 MiB 2.38 MiB
ef18299 17.75 MiB 20.13 MiB 2.38 MiB
a9355d1 17.74 MiB 20.10 MiB 2.36 MiB
4a86286 17.75 MiB 20.13 MiB 2.38 MiB
6858e4c 17.75 MiB 20.12 MiB 2.37 MiB

Previous results on branch: antonis/test-dispathc-qo-class

Startup times

Revision Plain With Sentry Diff
7769a91 448.58 ms 435.27 ms -13.31 ms
bdcf1ba 437.06 ms 422.84 ms -14.22 ms

App size

Revision Plain With Sentry Diff
7769a91 17.75 MiB 20.15 MiB 2.40 MiB
bdcf1ba 17.75 MiB 20.15 MiB 2.40 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.80 ms 1226.67 ms 5.88 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1219.45 ms 1236.33 ms 16.88 ms
60da2b3+dirty 1212.45 ms 1222.61 ms 10.16 ms
6492e76+dirty 1218.27 ms 1221.04 ms 2.78 ms
9c4a204+dirty 1231.46 ms 1239.71 ms 8.25 ms
438739d+dirty 1213.33 ms 1216.20 ms 2.88 ms
1dfac94+dirty 1224.62 ms 1217.02 ms -7.60 ms
09a2115+dirty 1233.45 ms 1229.50 ms -3.95 ms
3620199+dirty 1214.30 ms 1212.92 ms -1.38 ms
a9355d1+dirty 1236.78 ms 1245.20 ms 8.43 ms
e4aeaad+dirty 1241.18 ms 1235.51 ms -5.67 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.36 MiB 3.10 MiB 755.61 KiB
60da2b3+dirty 2.63 MiB 3.74 MiB 1.11 MiB
6492e76+dirty 2.63 MiB 3.78 MiB 1.14 MiB
9c4a204+dirty 2.36 MiB 3.08 MiB 735.56 KiB
438739d+dirty 2.63 MiB 3.70 MiB 1.07 MiB
1dfac94+dirty 2.63 MiB 3.78 MiB 1.14 MiB
09a2115+dirty 2.63 MiB 3.75 MiB 1.12 MiB
3620199+dirty 2.63 MiB 3.78 MiB 1.15 MiB
a9355d1+dirty 2.36 MiB 3.12 MiB 779.40 KiB
e4aeaad+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Previous results on branch: antonis/test-dispathc-qo-class

Startup times

Revision Plain With Sentry Diff
7769a91+dirty 1217.81 ms 1227.98 ms 10.17 ms
bdcf1ba+dirty 1223.96 ms 1230.37 ms 6.41 ms

App size

Revision Plain With Sentry Diff
7769a91+dirty 2.63 MiB 3.78 MiB 1.14 MiB
bdcf1ba+dirty 2.63 MiB 3.78 MiB 1.14 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.04 ms 403.16 ms 26.12 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6858e4c+dirty 387.81 ms 376.10 ms -11.71 ms
a9355d1+dirty 374.27 ms 435.52 ms 61.25 ms
7140a40+dirty 419.33 ms 463.16 ms 43.83 ms
9c4a204+dirty 440.30 ms 484.81 ms 44.52 ms
e4aeaad+dirty 379.82 ms 379.89 ms 0.08 ms
6492e76+dirty 378.44 ms 380.92 ms 2.48 ms
62e1450+dirty 363.60 ms 401.13 ms 37.53 ms
438739d+dirty 394.50 ms 432.00 ms 37.50 ms
77364bc+dirty 368.47 ms 411.62 ms 43.16 ms
12e4be5+dirty 434.66 ms 447.90 ms 13.24 ms

App size

Revision Plain With Sentry Diff
6858e4c+dirty 7.15 MiB 8.39 MiB 1.23 MiB
a9355d1+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7140a40+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9c4a204+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e4aeaad+dirty 7.15 MiB 8.39 MiB 1.23 MiB
6492e76+dirty 7.15 MiB 8.40 MiB 1.25 MiB
62e1450+dirty 7.15 MiB 8.36 MiB 1.21 MiB
438739d+dirty 7.15 MiB 8.38 MiB 1.23 MiB
77364bc+dirty 7.15 MiB 8.36 MiB 1.21 MiB
12e4be5+dirty 7.15 MiB 8.39 MiB 1.23 MiB

Previous results on branch: antonis/test-dispathc-qo-class

Startup times

Revision Plain With Sentry Diff
bdcf1ba+dirty 396.43 ms 386.23 ms -10.20 ms
7769a91+dirty 369.37 ms 371.62 ms 2.26 ms

App size

Revision Plain With Sentry Diff
bdcf1ba+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7769a91+dirty 7.15 MiB 8.42 MiB 1.26 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.45 ms 1235.51 ms 9.06 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1231.73 ms 1234.63 ms 2.90 ms
60da2b3+dirty 1230.44 ms 1232.47 ms 2.03 ms
6492e76+dirty 1226.37 ms 1226.78 ms 0.41 ms
9c4a204+dirty 1250.62 ms 1244.24 ms -6.38 ms
438739d+dirty 1228.18 ms 1226.46 ms -1.73 ms
1dfac94+dirty 1230.76 ms 1231.53 ms 0.78 ms
09a2115+dirty 1232.63 ms 1244.80 ms 12.17 ms
3620199+dirty 1247.39 ms 1245.02 ms -2.37 ms
a9355d1+dirty 1231.51 ms 1239.04 ms 7.53 ms
e4aeaad+dirty 1212.94 ms 1216.24 ms 3.30 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.92 MiB 3.66 MiB 760.67 KiB
60da2b3+dirty 3.19 MiB 4.31 MiB 1.12 MiB
6492e76+dirty 3.19 MiB 4.34 MiB 1.16 MiB
9c4a204+dirty 2.92 MiB 3.64 MiB 741.21 KiB
438739d+dirty 3.19 MiB 4.27 MiB 1.08 MiB
1dfac94+dirty 3.19 MiB 4.35 MiB 1.16 MiB
09a2115+dirty 3.19 MiB 4.32 MiB 1.13 MiB
3620199+dirty 3.19 MiB 4.35 MiB 1.16 MiB
a9355d1+dirty 2.92 MiB 3.69 MiB 790.55 KiB
e4aeaad+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Previous results on branch: antonis/test-dispathc-qo-class

Startup times

Revision Plain With Sentry Diff
7769a91+dirty 1232.31 ms 1232.26 ms -0.05 ms
bdcf1ba+dirty 1202.82 ms 1204.33 ms 1.52 ms

App size

Revision Plain With Sentry Diff
7769a91+dirty 3.19 MiB 4.34 MiB 1.16 MiB
bdcf1ba+dirty 3.19 MiB 4.34 MiB 1.16 MiB

@antonis antonis changed the title DRAFT: Test with QOS_CLASS_DEFAULT DRAFT: Test with QOS_CLASS_DEFAULT/QOS_CLASS_UTILITY May 21, 2025
@antonis antonis changed the title DRAFT: Test with QOS_CLASS_DEFAULT/QOS_CLASS_UTILITY DRAFT: Test with QOS_CLASS Priority May 21, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from 98197e3 to 4043e43 Compare May 22, 2025 08:15
@antonis
Copy link
Copy Markdown
Contributor Author

antonis commented May 22, 2025

Closing this as it served the purpose of testing on CI

@antonis antonis closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants