From 2cb0edc875438f95a47f5c714ac6bb4df438ff6c Mon Sep 17 00:00:00 2001 From: Krystof Woldrich Date: Thu, 22 May 2025 16:42:57 +0200 Subject: [PATCH 1/3] !remove(sdk): Delete deprecated `captureUserFeedback` --- CHANGELOG.md | 1 + packages/core/src/js/index.ts | 2 +- packages/core/src/js/sdk.tsx | 14 -------------- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fa5684843d..e34ac0a16a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ Version 7 of the SDK is compatible with Sentry self-hosted versions 24.4.2 or hi - `shutdownTimeout` moved from `core` to `@sentry/react-native` - `hasTracingEnabled` was renamed to `hasSpansEnabled` - You can no longer drop spans or return null on `beforeSendSpan` hook +- `Sentry.captureUserFeedback` removed, use `Sentry.captureFeedback` instead ([#4855](https://github.com/getsentry/sentry-react-native/pull/4855)) ### Removed types diff --git a/packages/core/src/js/index.ts b/packages/core/src/js/index.ts index fb931312d9..f5de2fd307 100644 --- a/packages/core/src/js/index.ts +++ b/packages/core/src/js/index.ts @@ -60,7 +60,7 @@ export { SDK_NAME, SDK_VERSION } from './version'; export type { ReactNativeOptions } from './options'; export { ReactNativeClient } from './client'; -export { init, wrap, nativeCrash, flush, close, captureUserFeedback, withScope, crashedLastRun } from './sdk'; +export { init, wrap, nativeCrash, flush, close, withScope, crashedLastRun } from './sdk'; export { TouchEventBoundary, withTouchEventBoundary } from './touchevents'; export { diff --git a/packages/core/src/js/sdk.tsx b/packages/core/src/js/sdk.tsx index fefa97d0c1..68d5af6df9 100644 --- a/packages/core/src/js/sdk.tsx +++ b/packages/core/src/js/sdk.tsx @@ -220,20 +220,6 @@ export async function close(): Promise { } } -/** - * Captures user feedback and sends it to Sentry. - * @deprecated Use `Sentry.captureFeedback` instead. - */ -export function captureUserFeedback(feedback: UserFeedback): void { - const feedbackParams: SendFeedbackParams = { - name: feedback.name, - email: feedback.email, - message: feedback.comments, - associatedEventId: feedback.event_id, - }; - captureFeedback(feedbackParams); -} - /** * Creates a new scope with and executes the given operation within. * The scope is automatically removed once the operation From 863b6ce09eebfd1b009542b57dae37d949e3fbe5 Mon Sep 17 00:00:00 2001 From: Krystof Woldrich Date: Wed, 28 May 2025 10:57:02 +0200 Subject: [PATCH 2/3] fix changelog --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7a12b3b235..2e286bd56c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ ## Unreleased +### Major Changes + +- `Sentry.captureUserFeedback` removed, use `Sentry.captureFeedback` instead ([#4855](https://github.com/getsentry/sentry-react-native/pull/4855)) + ### Changes - Use `Replay` interface for `browserReplayIntegration` return type ([#4858](https://github.com/getsentry/sentry-react-native/pull/4858)) @@ -48,7 +52,6 @@ Version 7 of the SDK is compatible with Sentry self-hosted versions 24.4.2 or hi - `shutdownTimeout` moved from `core` to `@sentry/react-native` - `hasTracingEnabled` was renamed to `hasSpansEnabled` - You can no longer drop spans or return null on `beforeSendSpan` hook -- `Sentry.captureUserFeedback` removed, use `Sentry.captureFeedback` instead ([#4855](https://github.com/getsentry/sentry-react-native/pull/4855)) ### Removed types From 296c4c25f148188b2c87468fd9b5bebae4001b3a Mon Sep 17 00:00:00 2001 From: Krystof Woldrich Date: Wed, 28 May 2025 10:58:56 +0200 Subject: [PATCH 3/3] fix unused imports --- packages/core/src/js/sdk.tsx | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/packages/core/src/js/sdk.tsx b/packages/core/src/js/sdk.tsx index f8716e74ca..b0f2ad5704 100644 --- a/packages/core/src/js/sdk.tsx +++ b/packages/core/src/js/sdk.tsx @@ -1,6 +1,16 @@ /* eslint-disable complexity */ -import type { Breadcrumb, BreadcrumbHint, Integration, Scope, SendFeedbackParams, UserFeedback } from '@sentry/core'; -import { captureFeedback, getClient, getGlobalScope, getIntegrationsToSetup, getIsolationScope, initAndBind, logger, makeDsn, stackParserFromStackParserOptions, withScope as coreWithScope } from '@sentry/core'; +import type { Breadcrumb, BreadcrumbHint, Integration, Scope } from '@sentry/core'; +import { + getClient, + getGlobalScope, + getIntegrationsToSetup, + getIsolationScope, + initAndBind, + logger, + makeDsn, + stackParserFromStackParserOptions, + withScope as coreWithScope, +} from '@sentry/core'; import { defaultStackParser, makeFetchTransport,