Skip to content

chore(utils): Use single encodeUTF8 impl#4885

Merged
krystofwoldrich merged 2 commits into
v7from
kw-unify-encode-utf8
Jun 4, 2025
Merged

chore(utils): Use single encodeUTF8 impl#4885
krystofwoldrich merged 2 commits into
v7from
kw-unify-encode-utf8

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich commented Jun 3, 2025

📢 Type of change

  • Enhancement

📜 Description

Just a small refactor to use the same encode function through the whole SDK.

fixes: #4883

💡 Motivation and Context

💚 How did you test it?

sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.55 ms 1218.56 ms -4.00 ms
Size 2.63 MiB 3.78 MiB 1.15 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
3c99746+dirty 1215.12 ms 1222.31 ms 7.18 ms

App size

Revision Plain With Sentry Diff
3c99746+dirty 2.63 MiB 3.78 MiB 1.15 MiB

Copy link
Copy Markdown
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.16 ms 1228.19 ms -1.98 ms
Size 3.19 MiB 4.35 MiB 1.16 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
3c99746+dirty 1227.65 ms 1228.81 ms 1.16 ms

App size

Revision Plain With Sentry Diff
3c99746+dirty 3.19 MiB 4.35 MiB 1.16 MiB

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.02 ms 401.02 ms 18.00 ms
Size 7.15 MiB 8.34 MiB 1.18 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
3c99746+dirty 400.65 ms 399.59 ms -1.06 ms

App size

Revision Plain With Sentry Diff
3c99746+dirty 7.15 MiB 8.34 MiB 1.18 MiB

@krystofwoldrich krystofwoldrich merged commit 78c414f into v7 Jun 4, 2025
67 of 70 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-unify-encode-utf8 branch June 4, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants