feat(breadcrumbs): Add environment aware defaults for RN/Expo/Web#4886
Merged
Conversation
krystofwoldrich
changed the title
Contributor
|
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
krystofwoldrich
force-pushed
the
kw-breadcrumbs
branch
from
19ff46f to
07c87c6
Compare
antonis
approved these changes
Jun 4, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thank you for documenting and adding tests 🙇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR fixes
window.addEventListerneris not a function error, which was logged out on the v7 branch during thebreadcrumbsIntegrationsetup.The error was caused by the history handler which was recently refactored in the browser SDK.
This PR adds a wrapper around the browser integration changing the defaults if the SDK runs on RN and on Web.
💚 How did you test it?
sample apps, unit tests
📝 Checklist
sendDefaultPIIis enabled